Repository navigation
Remove the unused TouchableBounce implementation - #58740
Closed
rubennorte wants to merge 1 commit into
Closed
rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
Summary: Migrate the remaining TouchableBounce consumers to Pressable, then remove the private implementation and macOS synchronization entry now that nothing imports it. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D122129382
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122129382. |
cortinico
approved these changes
Sep 29, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in f7fc079. |
1 of 3 tasks
huntie
added a commit
to expo/expo
that referenced
this pull request
Oct 6, 2026
# Summary React Native removed `TouchableBounce` upstream in [react/react-native#58740](react/react-native#58740). It still ships in 0.88 but will be gone from the next release cut from `main`. Remove the native-component-list demo screen, its only importer in Expo, before that lands. Linear: [ENG-27844](https://linear.app/expo/issue/ENG-27844/migrate-remaining-expo-react-nativelibraries-deep-imports) (parent ENG-27600) # Test Plan ```sh pnpm --filter native-component-list tsc ``` - ✅ No remaining `TouchableBounce` references outside generated bundles. **Smoke test** native-component-list on iOS with this commit checked out. | iPhone 18 Pro | |---| | <img src="https://github.com/user-attachments/assets/6c9b681e-be22-4f10-b2e0-0b8d0e2bac8e" width="300" alt="native-component-list on iPhone 18 Pro"> | ✅ App builds and bundles # Checklist - [x] I added a changeset and followed [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Migrate the remaining TouchableBounce consumers to Pressable, then remove the private implementation and macOS synchronization entry now that nothing imports it.
Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D122129382