Emit umbrella header includes from codegen - #58730
Open
j-piasecki wants to merge 1 commit into
Open
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122317911. |
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D122317911
branch
from
September 29, 2026 10:24
91c8bbb to
fdb73ef
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
Summary: Codegen output is compiled in consumer targets, so it now includes React Native through module umbrella headers (`<React/RendererCore.h>`, `<React/Graphics.h>`, `<React/NativeModuleCore.h>`, etc.) instead of fine-grained paths, which hard-error under `RN_STRICT_API`. Changelog: [General][Changed] - Codegen-generated C++ includes React Native through module umbrella headers Differential Revision: D122317911
Summary: Codegen output is compiled in consumer targets, so it now includes React Native through module umbrella headers (`<React/RendererCore.h>`, `<React/Graphics.h>`, `<React/NativeModuleCore.h>`, etc.) instead of fine-grained paths, which hard-error under `RN_STRICT_API`. The one exception is `<react/renderer/debug/debugStringConvertibleUtils.h>`, which `Props.cpp` still includes directly alongside `<React/RendererDebug.h>`. It is a private header not re-exported by any umbrella, but it is only emitted together with the `getDebugProps` implementation, which is generated solely for React Native's own core components library (`FBReactNativeSpec`). That library is built as part of React Native (`RN_BUILDING`), so the private-header guard does not apply. Changelog: [General][Changed] - Codegen-generated C++ includes React Native through module umbrella headers Differential Revision: D122317911
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D122317911
branch
from
September 29, 2026 11:16
fdb73ef to
4ec4587
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Codegen output is compiled in consumer targets, so it now includes React Native through module umbrella headers (
<React/RendererCore.h>,<React/Graphics.h>,<React/NativeModuleCore.h>, etc.) instead of fine-grained paths, which hard-error underRN_STRICT_API.The one exception is
<react/renderer/debug/debugStringConvertibleUtils.h>, whichProps.cppstill includes directly alongside<React/RendererDebug.h>. It is a private header not re-exported by any umbrella, but it is only emitted together with thegetDebugPropsimplementation, which is generated solely for React Native's own core components library (FBReactNativeSpec). That library is built as part of React Native (RN_BUILDING), so the private-header guard does not apply.Changelog:
[General][Changed] - Codegen-generated C++ includes React Native through module umbrella headers
Differential Revision: D122317911