Skip to content

Use module umbrella headers in react/renderer/animated headers (#58729) #58729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use module umbrella headers in react/renderer/animated headers (#58729) #58729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/React-Fabric.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ Pod::Spec.new do |s|

s.subspec "animated" do |ss|
ss.dependency "React-Fabric/animationbackend"
ss.dependency "React-Fabric/coreUmbrella"
ss.dependency "ReactCommon/turbomodule/coreUmbrella"
ss.source_files = podspec_sources("react/renderer/animated/**/*.{m,mm,cpp,h}", "react/renderer/animated/**/*.{h}")
ss.exclude_files = "react/renderer/animated/tests"
ss.header_dir = "react/renderer/animated"
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/animated/AnimatedModule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
#else
#include <FBReactNativeSpec/FBReactNativeSpecJSI.h>
#endif
#include <ReactCommon/TurboModuleWithJSIBindings.h>
#include <React/NativeModuleCore.h>
#include <React/RendererCore.h>
#include <folly/dynamic.h>
#include <react/renderer/animated/NativeAnimatedNodesManager.h>
#include <react/renderer/animated/NativeAnimatedNodesManagerProvider.h>
#include <react/renderer/core/ReactPrimitives.h>
#include <memory>
#include <string>
#include <variant>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/animated/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ target_link_libraries(react_renderer_animated
react_renderer_uimanager
react_renderer_scheduler
react_renderer_animationbackend
react_bridging
react_nativemodule_core
glog
folly_runtime
)
Expand Down
3 changes: 1 addition & 2 deletions packages/react-native/ReactCommon/react/renderer/animated/EventEmitterListener.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
#include <mutex>
#include <shared_mutex>

#include <react/renderer/core/EventPayload.h>
#include <react/renderer/core/ReactPrimitives.h>
#include <React/RendererCore.h>

namespace facebook::react {

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/animated/MergedValueDispatcher.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <React/RendererCore.h>
#include <folly/dynamic.h>
#include <react/renderer/core/ReactPrimitives.h>
#include <functional>
#include <mutex>

Expand Down
7 changes: 3 additions & 4 deletions packages/react-native/ReactCommon/react/renderer/animated/NativeAnimatedNodesManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,14 @@
#else
#include <FBReactNativeSpec/FBReactNativeSpecJSI.h>
#endif
#include <React/Bridging.h>
#include <React/Debug.h>
#include <React/RendererCore.h>
#include <folly/dynamic.h>
#include <react/bridging/Function.h>
#include <react/debug/flags.h>
#include <react/renderer/animated/EventEmitterListener.h>
#include <react/renderer/animated/event_drivers/EventAnimationDriver.h>
#include <react/renderer/animationbackend/AnimatedPropsBuilder.h>
#include <react/renderer/animationbackend/AnimationBackend.h>
#include <react/renderer/core/ReactPrimitives.h>
#include <react/renderer/core/ShadowNode.h>
#include <react/renderer/uimanager/UIManagerAnimationBackend.h>
#include <chrono>
#include <memory>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/animated/drivers/AnimationDriver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

#pragma once

#include <react/debug/flags.h>
#include <React/Debug.h>
#include <react/renderer/animated/NativeAnimatedNodesManager.h>

namespace facebook::react {
Expand Down
3 changes: 1 addition & 2 deletions ...ges/react-native/ReactCommon/react/renderer/animated/event_drivers/EventAnimationDriver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@

#pragma once

#include <react/renderer/core/EventPayload.h>
#include <react/renderer/core/ReactPrimitives.h>
#include <React/RendererCore.h>
#include <optional>
#include <string>
#include <vector>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/animated/internal/primitives.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include <react/renderer/core/ReactPrimitives.h>
#include <React/RendererCore.h>

namespace facebook::react::animated {
// Indicates that the animated node identifier is not defined.
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/animated/nodes/AnimatedNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@

#pragma once

#include <React/Debug.h>
#include <React/RendererCore.h>
#include <folly/dynamic.h>
#include <react/debug/flags.h>
#include <react/renderer/core/ReactPrimitives.h>

namespace facebook::react {

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/animated/nodes/ColorAnimatedNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

#include "AnimatedNode.h"

#include <react/renderer/graphics/Color.h>
#include <React/Graphics.h>

namespace facebook::react {
class ColorAnimatedNode final : public AnimatedNode {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/animated/nodes/InterpolationAnimatedNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@

#include "ValueAnimatedNode.h"

#include <React/Graphics.h>
#include <react/renderer/animated/internal/primitives.h>
#include <react/renderer/graphics/Color.h>

namespace facebook::react {

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/animated/nodes/PropsAnimatedNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@

#include "AnimatedNode.h"

#include <React/RendererCore.h>
#include <react/renderer/animated/internal/primitives.h>
#include <react/renderer/core/ShadowNode.h>
#include <mutex>

namespace facebook::react {
Expand Down
4 changes: 0 additions & 4 deletions packages/react-native/ReactCommon/react/renderer/graphics/React/Graphics.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@
#include <react/renderer/graphics/fromRawValueShared.h>
#include <react/renderer/graphics/rounding.h>

#ifdef ANDROID
#include <react/renderer/graphics/configurePlatformColorCacheInvalidationHook.h>
#endif

#if defined(__APPLE__) && defined(__OBJC__)
#include <react/renderer/graphics/RCTPlatformColorUtils.h>
#endif
Expand Down
Loading