Use module umbrella headers in react/renderer/animations (#58728) - #58728
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122311313. |
facebook-github-tools
Bot
added
p: Software Mansion
meta-codesync
Bot
changed the title
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
Summary: Headers in `react/renderer/animations` included fine-grained public headers from other modules that are protected by `UmbrellaGuard.h`, which hard-errors under `RN_STRICT_API` unless included through the module umbrella. Switch these includes to the corresponding umbrellas: - `react/renderer/core/ReactPrimitives.h` -> `React/RendererCore.h` - `react/renderer/core/RawValue.h` -> `React/RawValue.h` - `react/renderer/debug/flags.h` -> `React/RendererDebug.h` - `react/renderer/graphics/Float.h` -> `React/Graphics.h` - `ReactCommon/RuntimeExecutor.h` -> `React/RuntimeExecutor.h` For-frameworks headers (`mounting`, `uimanager`) have no umbrella and are left as-is. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D122311313
j-piasecki
force-pushed
the
export-D122311313
branch
from
September 29, 2026 13:11
2656074 to
24fd31e
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 29, 2026
Summary: Headers in `react/renderer/animations` included fine-grained public headers from other modules that are protected by `UmbrellaGuard.h`, which hard-errors under `RN_STRICT_API` unless included through the module umbrella. Switch these includes to the corresponding umbrellas: - `react/renderer/core/ReactPrimitives.h` -> `React/RendererCore.h` - `react/renderer/core/RawValue.h` -> `React/RawValue.h` - `react/renderer/debug/flags.h` -> `React/RendererDebug.h` - `react/renderer/graphics/Float.h` -> `React/Graphics.h` - `ReactCommon/RuntimeExecutor.h` -> `React/RuntimeExecutor.h` For-frameworks headers (`mounting`, `uimanager`) have no umbrella and are left as-is. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D122311313
j-piasecki
force-pushed
the
export-D122311313
branch
from
September 29, 2026 13:12
24fd31e to
1a1db71
Compare
Summary: Pull Request resolved: react#58728 Headers in `react/renderer/animations` included fine-grained public headers from other modules that are protected by `UmbrellaGuard.h`, which hard-errors under `RN_STRICT_API` unless included through the module umbrella. Switch these includes to the corresponding umbrellas: - `react/renderer/core/ReactPrimitives.h` -> `React/RendererCore.h` - `react/renderer/core/RawValue.h` -> `React/RawValue.h` - `react/renderer/debug/flags.h` -> `React/RendererDebug.h` - `react/renderer/graphics/Float.h` -> `React/Graphics.h` - `ReactCommon/RuntimeExecutor.h` -> `React/RuntimeExecutor.h` For-frameworks headers (`mounting`, `uimanager`) have no umbrella and are left as-is. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D122311313
j-piasecki
force-pushed
the
export-D122311313
branch
from
September 29, 2026 13:15
1a1db71 to
cf8cfc6
Compare
|
This pull request has been merged in a6c6fe9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Headers in
react/renderer/animationsincluded fine-grained public headers from other modules that are protected byUmbrellaGuard.h, which hard-errors underRN_STRICT_APIunless included through the module umbrella. Switch these includes to the corresponding umbrellas:react/renderer/core/ReactPrimitives.h->React/RendererCore.hreact/renderer/core/RawValue.h->React/RawValue.hreact/renderer/debug/flags.h->React/RendererDebug.hreact/renderer/graphics/Float.h->React/Graphics.hReactCommon/RuntimeExecutor.h->React/RuntimeExecutor.hFor-frameworks headers (
mounting,uimanager) have no umbrella and are left as-is.Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D122311313