Conversation
Summary: `I18nUtil` directly called `Configuration.getLocales()`, which is unavailable before API 24. Read the preferred locale through `ConfigurationCompat` instead and fall back to the process default when the locale list is empty. Add an API-23 Robolectric regression test that exercises RTL detection on an Arabic locale. Changelog: [Android][Fixed] - Prevent a crash when resolving RTL layout direction on Android 6 Reviewed By: cortinico Differential Revision: D122147089
meta-cla
Bot
added
the
CLA Signed
|
@shreeshga has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122147089. |
cortinico
approved these changes
Sep 28, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in eaa9d7f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I18nUtildirectly calledConfiguration.getLocales(), which is unavailable before API 24. Read the preferred locale throughConfigurationCompatinstead and fall back to the process default when the locale list is empty.Add an API-23 Robolectric regression test that exercises RTL detection on an Arabic locale.
Changelog:
[Android][Fixed] - Prevent a crash when resolving RTL layout direction on Android 6
Reviewed By: cortinico
Differential Revision: D122147089