Skip to content

Fix stale layout when a child switches to display: contents after insertion #58721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cipolleschi wants to merge 1 commit into from
Closed

Fix stale layout when a child switches to display: contents after insertion #58721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/react-native/ReactCommon/yoga/yoga/YGNodeStyle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,16 @@ YGOverflow YGNodeStyleGetOverflow(const YGNodeConstRef node) {
}

void YGNodeStyleSetDisplay(const YGNodeRef node, const YGDisplay display) {
const bool wasContents =
resolveRef(node)->style().display() == Display::Contents;
updateStyle<&Style::display, &Style::setDisplay>(node, scopedEnum(display));

// The owner caches how many of its children use display: contents, so it
// has to be recomputed when an attached child switches to or from it.
auto owner = resolveRef(node)->getOwner();
if (owner != nullptr && wasContents != (display == YGDisplayContents)) {
owner->setChildren(owner->getChildren());
}
}

YGDisplay YGNodeStyleGetDisplay(const YGNodeConstRef node) {
Expand Down
Loading