Include umbrella headers from jsinspector-modern (#58707) - #58707
Open
j-piasecki wants to merge 1 commit into
Open
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D122118482. |
Summary: `jsinspector-modern` headers included three public-tier headers directly: `react/timing/primitives.h`, `react/utils/OnScopeExit.h` and `ReactCommon/RuntimeExecutor.h`. These are protected by `UmbrellaGuard.h`, so any consumer that defined `RN_STRICT_API` and included one of the affected jsinspector headers (e.g. `RuntimeTarget.h`, `HostTarget.h`, `ReactCdp.h`) hit a hard `#error`, even with `RN_ALLOW_FRAMEWORKS` defined. Switch to the module umbrellas `<React/Timing.h>`, `<React/Utils.h>` and `<React/RuntimeExecutor.h>`, and declare the `react/timing` dependency that was previously used without being declared (BUCK, CMake, CocoaPods). Changelog: [Internal] Differential Revision: D122118482
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D122118482
branch
from
September 29, 2026 07:15
31ed56c to
bd801ba
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
jsinspector-modernheaders included three public-tier headers directly:react/timing/primitives.h,react/utils/OnScopeExit.handReactCommon/RuntimeExecutor.h. These are protected byUmbrellaGuard.h, so any consumer that definedRN_STRICT_APIand included one of the affected jsinspector headers (e.g.RuntimeTarget.h,HostTarget.h,ReactCdp.h) hit a hard#error, even withRN_ALLOW_FRAMEWORKSdefined.Switch to the module umbrellas
<React/Timing.h>,<React/Utils.h>and<React/RuntimeExecutor.h>, and declare thereact/timingdependency that was previously used without being declared (BUCK, CMake, CocoaPods).Changelog: [Internal]
Differential Revision: D122118482