Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121046662. |
meta-codesync
Bot
changed the title
javache
force-pushed
the
export-D121046662
branch
from
September 21, 2026 19:27
2de4b5d to
1778951
Compare
Summary: Restore idiomatic Objective-C fast enumeration now that React Native no longer enables the incompatible `cppcoreguidelines-init-variables` check. Changelog: [Internal] Differential Revision: D121040575
Summary: Consolidate split superclass initializer assignments and validity checks into the canonical assignment-in-condition form. Configure `readability-implicit-bool-conversion` to allow pointer conditions so clang-tidy accepts that Objective-C idiom while retaining its other implicit-conversion coverage. Changelog: [Internal] Differential Revision: D121046662
javache
force-pushed
the
export-D121046662
branch
from
September 21, 2026 20:08
1778951 to
491eeff
Compare
|
This pull request has been merged in 1774243. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Consolidate split superclass initializer assignments and validity checks into the canonical assignment-in-condition form. Configure
readability-implicit-bool-conversionto allow pointer conditions so clang-tidy accepts that Objective-C idiom while retaining its other implicit-conversion coverage.Changelog: [Internal]
Differential Revision: D121046662