Conversation
meta-cla
Bot
added
the
CLA Signed
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120529435. |
facebook-github-tools
Bot
added
p: Software Mansion
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 17, 2026
Summary: Pull Request resolved: react#58571 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120529435
meta-codesync
Bot
changed the title
coado
force-pushed
the
export-D120529435
branch
from
September 17, 2026 16:14
c8aa62d to
0571c3e
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 18, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120529435
coado
force-pushed
the
export-D120529435
branch
from
September 18, 2026 14:07
0571c3e to
9bec0f0
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 18, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120529435
cortinico
approved these changes
Sep 18, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120529435
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120529435
coado
force-pushed
the
export-D120529435
branch
from
September 21, 2026 14:33
9bec0f0 to
76cca31
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120529435
coado
force-pushed
the
export-D120529435
branch
from
September 21, 2026 14:33
76cca31 to
8ca6ea5
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: react#58571 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120529435
coado
force-pushed
the
export-D120529435
branch
from
September 21, 2026 14:36
8ca6ea5 to
c3b850b
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120529435
coado
force-pushed
the
export-D120529435
branch
from
September 21, 2026 19:01
c3b850b to
4defa27
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120529435
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: react#58571 Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120529435
coado
force-pushed
the
export-D120529435
branch
from
September 21, 2026 19:04
4defa27 to
51f7604
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 22, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120529435
coado
force-pushed
the
export-D120529435
branch
from
September 22, 2026 09:28
51f7604 to
282923c
Compare
Summary: Source-built CocoaPods frameworks do not automatically expose the directories behind stable <React/...> umbrella includes. Exported and generated headers consume umbrellas owned by sibling frameworks, while consuming application and pod targets do not automatically inherit the header roots for those frameworks. Add source-only aggregate paths for the umbrella frameworks used by FabricComponents and React-perflogger, configure the React-timing dependency of React-perflogger with its framework header root, and expose React-bridging to generated module targets. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120992289
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120529435
coado
force-pushed
the
export-D120529435
branch
from
September 22, 2026 12:16
282923c to
9c13bfa
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 22, 2026
Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D120529435
|
This pull request has been merged in d381a99. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the text module with strict API enforcement enabled.
Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D120529435