Skip to content

[iOS][swiftpm] Drop the unused publicHeadersPath from spm.modules #58059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrfalch wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −5
Open

[iOS][swiftpm] Drop the unused publicHeadersPath from spm.modules #58059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react-native/scripts/spm/__docs__/spm-scripts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,6 @@ module.exports = {
name: 'MyNativeModule',
path: 'ios/MyNativeModule', // relative to app root
exclude: ['*.podspec'], // optional
publicHeadersPath: '.', // optional
},
],
},
Expand Down
5 changes: 3 additions & 2 deletions packages/react-native/scripts/spm/generate-spm-autolinking.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ function readAutolinkingJson(
* name: "MyNativeModule",
* path: "ios/MyNativeModule", // relative to appRoot
* exclude: ["*.js", "*.podspec"], // optional
* publicHeadersPath: ".", // optional
* }
* ]
* }
Expand Down Expand Up @@ -1334,7 +1333,9 @@ function main(argv /*:: ?: Array<string> */) /*: void */ {
name: mod.name,
path: relPath,
exclude: mod.exclude ?? [],
publicHeadersPath: mod.publicHeadersPath ?? null,
// The synth wrapper owns the module's public interface: it declares
// publicHeadersPath: "include", a symlink to the module's header tree.
publicHeadersPath: null,
sources: userSources,
},
origin: 'spmModule',
Expand Down
1 change: 0 additions & 1 deletion packages/react-native/scripts/spm/spm-types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ export type SpmModuleConfig = {
name: string,
path: string,
exclude?: Array<string>,
publicHeadersPath?: ?string,
// Optional CocoaPods-style glob allowlist (analog of s.source_files).
// When set, replaces auto source discovery for the module — only files
// matching one of these patterns are passed to SPM via `sources:`.
Expand Down
1 change: 0 additions & 1 deletion packages/rn-tester/react-native.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ module.exports = {
{
name: 'ReactCommonSamples',
path: '../react-native/ReactCommon/react/nativemodule/samples/platform/ios',
publicHeadersPath: '.',
},
{
name: 'ReactRCTPushNotification',
Expand Down
Loading