Skip to content

Cover react/renderer/consistency:consistency with Stable API guards #58046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cover react/renderer/consistency:consistency with Stable API guards #58046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/consistency/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,7 @@ file(GLOB react_renderer_consistency_SRC CONFIGURE_DEPENDS *.cpp)
add_library(react_renderer_consistency OBJECT ${react_renderer_consistency_SRC})

target_include_directories(react_renderer_consistency PUBLIC ${REACT_COMMON_DIR})

target_link_libraries(react_renderer_consistency react_cxxstableapi)
target_compile_reactnative_options(react_renderer_consistency PRIVATE)
target_compile_options(react_renderer_consistency PRIVATE -Wpedantic)
2 changes: 2 additions & 0 deletions ...ges/react-native/ReactCommon/react/renderer/consistency/React-rendererconsistency.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,7 @@ Pod::Spec.new do |s|

resolve_use_frameworks(s, header_mappings_dir: "../../..", module_name: "React_rendererconsistency")

s.dependency "React-cxxstableapi"

mark_as_react_native_build(s)
end
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/consistency/ScopedShadowTreeRevisionLock.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h>

namespace facebook::react {
Expand Down
2 changes: 2 additions & 0 deletions ...eact-native/ReactCommon/react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

namespace facebook::react {

/**
Expand Down
3 changes: 2 additions & 1 deletion packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <ReactCommon/RuntimeExecutor.h>
#include <jsi/hermes-interfaces.h>
#include <react/performance/timeline/PerformanceEntryReporter.h>
#include <react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h>
#include <react/renderer/runtimescheduler/SchedulerPriorityUtils.h>
#include <react/renderer/runtimescheduler/Task.h>
#include <react/timing/primitives.h>
Expand All @@ -20,6 +19,8 @@

namespace facebook::react {

class ShadowTreeRevisionConsistencyManager;

using RuntimeSchedulerRenderingUpdate = std::function<void()>;
using SurfaceId = int32_t;

Expand Down
3 changes: 2 additions & 1 deletion packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Legacy.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#ifndef RCT_REMOVE_LEGACY_ARCH

#include <ReactCommon/RuntimeExecutor.h>
#include <react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h>
#include <react/renderer/runtimescheduler/RuntimeScheduler.h>
#include <react/renderer/runtimescheduler/Task.h>
#include <atomic>
Expand All @@ -19,6 +18,8 @@

namespace facebook::react {

class ShadowTreeRevisionConsistencyManager;

class RuntimeScheduler_Legacy final : public RuntimeSchedulerBase {
public:
explicit RuntimeScheduler_Legacy(
Expand Down
3 changes: 2 additions & 1 deletion packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#pragma once

#include <ReactCommon/RuntimeExecutor.h>
#include <react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h>
#include <react/renderer/runtimescheduler/RuntimeScheduler.h>
#include <react/renderer/runtimescheduler/Task.h>
#include <atomic>
Expand All @@ -18,6 +17,8 @@

namespace facebook::react {

class ShadowTreeRevisionConsistencyManager;

class RuntimeScheduler_Modern final : public RuntimeSchedulerBase {
public:
explicit RuntimeScheduler_Modern(
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@
#include <cxxreact/TraceSection.h>
#include <react/debug/react_native_assert.h>
#include <react/featureflags/ReactNativeFeatureFlags.h>
#include <react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h>
#include <react/renderer/core/DynamicPropsUtilities.h>
#include <react/renderer/core/PropsParserContext.h>
#include <react/renderer/core/ShadowNodeFragment.h>
#include <react/renderer/uimanager/AppRegistryBinding.h>
#include <react/renderer/uimanager/UIManagerBinding.h>
#include <react/renderer/uimanager/UIManagerCommitHook.h>
#include <react/renderer/uimanager/UIManagerMountHook.h>
#include <react/renderer/uimanager/consistency/LazyShadowTreeRevisionConsistencyManager.h>

#include <glog/logging.h>

Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#include <shared_mutex>

#include <react/renderer/componentregistry/ComponentDescriptorRegistry.h>
#include <react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h>
#include <react/renderer/core/InstanceHandle.h>
#include <react/renderer/core/RawValue.h>
#include <react/renderer/core/ShadowNode.h>
Expand All @@ -28,13 +27,14 @@
#include <react/renderer/uimanager/UIManagerDelegate.h>
#include <react/renderer/uimanager/UIManagerNativeAnimatedDelegate.h>
#include <react/renderer/uimanager/UIManagerViewTransitionDelegate.h>
#include <react/renderer/uimanager/consistency/LazyShadowTreeRevisionConsistencyManager.h>
#include <react/renderer/uimanager/consistency/ShadowTreeRevisionProvider.h>
#include <react/renderer/uimanager/primitives.h>
#include <react/utils/ContextContainer.h>

namespace facebook::react {

class LazyShadowTreeRevisionConsistencyManager;
class ShadowTreeRevisionConsistencyManager;
class UIManagerBinding;
class UIManagerCommitHook;
class UIManagerMountHook;
Expand Down
Loading