fix: decimal values in transformOrigin string parser#57487
fix: decimal values in transformOrigin string parser#57487MayankSharma-2812 wants to merge 1 commit into
Conversation
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
Fixes incorrect parsing of decimal percentage and pixel values in the string form of
transformOrigin.The current tokenizer only matches integer numeric values followed by
%orpx. As a result, decimal pixel values are silently corrupted. For example:currently returns:
instead of:
Decimal percentage values are also incorrectly tokenized. For example,
50.5% 30.2%is split into partial matches instead of preserving the decimal values.This updates the numeric token pattern from
\d+(?:%|px)to\d*\.?\d+(?:%|px), supporting decimal values such as12.5px,50.5%, and leading-dot decimal values such as.5%.Regression coverage is added for decimal percentages, decimal pixels, and leading-dot decimal values.
Changelog:
[GENERAL] [FIXED] - Fix
transformOriginstring parsing for decimal percentage and pixel values.Test Plan:
Added regression coverage in
processTransformOrigin-itest.jsfor:50.5% 30.2%12.5px 7.5px.5% .5pxA focused local execution against
processTransformOriginconfirmed:Also attempted the targeted Fantom integration test with:
The Fantom test could not complete locally because Metro failed to resolve a generated runtime setup path containing Windows path separators.