fix: declare missing dependencies caught in pnpm mode#57474
Open
Saadnajmi wants to merge 3 commits into
Open
Conversation
Upstreaming part of microsoft#3010 (enabling Yarn v4's pnpm mode, which requires stricter dependency declarations). Several first-party packages import modules they don't declare, resolving only via a hoisted node_modules: - @react-native/metro-babel-transformer: metro-babel-transformer - @react-native/fantom: metro, metro-config, jest-docblock, jest-message-util, source-map - @react-native/babel-plugin-codegen: @babel/plugin-syntax-flow (devDependency) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
meta-cla
Bot
added
the
CLA Signed
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
facebook-github-tools
Bot
added
the
Shared with Meta
- source-map: ^0.7.4 -> ^0.6.1. Fantom uses the synchronous SourceMapConsumer constructor, which is the 0.6.x API; 0.7+ returns a Promise. 0.6.1 is also already resolved in the lockfile, avoiding a new major. - @babel/plugin-syntax-flow: ^7.25.0 -> ^7.26.0 to match the range already present in the lockfile. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Upstreaming part of microsoft#3010 (enabling Yarn v4's pnpm mode, which requires stricter dependency declarations). Several first-party packages import modules they don't declare, resolving only via a hoisted node_modules:
Changelog:
[GENERAL] [FIXED] - declare missing dependencies caught in pnpm mode
Test Plan:
CI should pass