CSS Grid algorithm 1/N: data structures (#57459)#57459
Open
rozele wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rozele has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110780559. |
Summary: Pull Request resolved: react#57459 First in a series of PRs splitting the grid layout algorithm into reviewable chunks. Addresses feedback from react/yoga#1894. ## Summary - Rename `style/GridTrack.h` to `style/GridTrackSize.h` to match the type it defines and CSS grid naming spec. - Remove layout state fields (`baseSize`, `growthLimit`, `infinitelyGrowable`) from `GridTrackSize` — these belong in the algorithm layer, not the style definition - Add `algorithm/grid/GridTrack.h`, wraps `GridTrackSize` with layout state via composition (removed inheritance) - Add `algorithm/grid/GridItem.h`, represents a grid item with its resolved position (after autoplacement algorithm) and flags used during track sizing algorithm X-link: react/yoga#1923 Differential Revision: D110780559 Pulled By: rozele
meta-codesync
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
First in a series of PRs splitting the grid layout algorithm into reviewable chunks. Addresses feedback from react/yoga#1894.
Summary
style/GridTrack.htostyle/GridTrackSize.hto match the type it defines and CSS grid naming spec.baseSize,growthLimit,infinitelyGrowable) fromGridTrackSize— these belong in the algorithm layer, not the style definitionalgorithm/grid/GridTrack.h, wrapsGridTrackSizewith layout state via composition (removed inheritance)algorithm/grid/GridItem.h, represents a grid item with its resolved position (after autoplacement algorithm) and flags used during track sizing algorithmX-link: react/yoga#1923
Differential Revision: D110780559
Pulled By: rozele