Conversation
Summary: Self-register commands from the `community-cli-plugin` package via `react-native.config.js` — meaning we can remove the redirect within `packages/react-native/react-native.config.js`. Progress towards removing `community-cli-plugin` as a direct dep of `react-native`, and paired with react-native-community/template#235. Changelog: [General][Breaking] - `react-native/community-cli-plugin` will no longer be auto-detected from `react-native`. It must now be specified in `devDependencies`. Differential Revision: D109869538
Summary: Depends on react-native-community/cli#2817. See also react-native-community/template#235. Progress towards deleting the `react-native.config.js` file we ship with `react-native`. These Community CLI plugins are moving back to being included by default (and in the first place, should not have been wired up here!). Changelog: [General][Changed] - Platform registration config for the Community CLI is removed from the `react-native` package. No breaking change with `react-native-community/cli` 21.x (required). Differential Revision: D109872883
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109872883. |
|
Hi @huntie! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary: Replaces #57353. Follows #58670. Depends on react-native-community/cli#2817. See also react-native-community/template#235 and react-native-community/template#254, which moves the template to CLI 21.0.0-alpha.1 (the template-app CI jobs here stay red until it lands). Deletes the `react-native.config.js` file we ship with `react-native`. The iOS and Android Community CLI platforms are moving back to being included by default (and in the first place, should not have been wired up here!), and all commands are self-registered by `react-native/community-cli-plugin`. RNTester moves to `react-native-community/cli` 21.0.0-alpha.1, which includes the iOS and Android platforms, and drops its `cli-platform-ios` and `cli-platform-android` devDependencies. HelloWorld gains the same CLI devDependency: its Gradle autolinking runs `npx react-native-community/cli config` after an `npm install` in the app, which otherwise fetches the `latest` (20.x) CLI. Changelog: [General][Changed] - Platform registration config for the Community CLI is removed from the `react-native` package. No breaking change with `react-native-community/cli` 21.x (required). Pull Request resolved: #58671 Test Plan: With `react-native-community/cli` 21.0.0-alpha.1 installed in the monorepo. **RNTester, HelloWorld, and a template-shaped app** (no `react-native.config.js` anywhere) - ✅ `react-native config` registers `ios` and `android` and resolves each project: `RNTesterPods.xcworkspace` / `com.facebook.react.uiapp`, `HelloWorld.xcworkspace` / `com.helloworld` - ✅ `react-native` is absent from `config` dependencies - ✅ `bundle`, `start`, `spm`, and `codegen` are registered by `react-native/community-cli-plugin` - ✅ `react-native bundle --platform ios --dev false` completes for RNTester Screenshots of the template-shaped app are in the react-native-community/cli#2817 test plan. **Internal validation** - ✅ `./xplat/yarn-validation/bin/yarn-validation` (validates `xplat/js`, `xplat/js/public`, and `xplat/js/react-native-github`) - ✅ Root `yarn install --offline --force --ignore-scripts --ignore-engines --ignore-platform --skip-integrity-check` - ✅ `arc lint` Reviewed By: cipolleschi Differential Revision: D122744239 Pulled By: cortinico fbshipit-source-id: 3e46c0f1021fa92863523f2b9865e8c0c770caa8
Summary:
Depends on react-native-community/cli#2817. See also react-native-community/template#235.
Progress towards deleting the
react-native.config.jsfile we ship withreact-native. These Community CLI plugins are moving back to being included by default (and in the first place, should not have been wired up here!).Changelog:
[General][Changed] - Platform registration config for the Community CLI is removed from the
react-nativepackage. No breaking change withreact-native-community/cli21.x (required).Differential Revision: D109872883