Repository navigation
docs: clarify correct usage of accessibilityRole "link" (fixes #3215) - #5287
Merged
Simek merged 1 commit intoOct 19, 2026
Merged
Conversation
Simek
reviewed
Oct 19, 2026
supunyasanthaofficial
force-pushed
the
fix/clarify-accessibility-role-link
branch
from
October 19, 2026 08:48
076e46a to
54b4d80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3215.
Summary
The current documentation for
accessibilityRole="link"androle="link"only says that the element should be treated as a link. This can be confusing when deciding whether to uselinkorbuttonfor in-app navigation.This PR clarifies that
linkshould be used for elements that open an external URL or web page, while buttons should be used for in-app navigation and actions.Changes
linkdescriptions indocs/accessibility.mdto explain when to uselinkinstead ofbutton.0.77through0.87.Test Plan
docs/accessibility.md.