Conversation
robhogan
added this pull request to stack #2016
October 3, 2026 21:33
meta-cla
Bot
added
the
CLA Signed
robhogan
marked this pull request as ready for review
October 3, 2026 21:35
robhogan
requested review from
huntie and
motiz88
and
a balanced review from Copilot
October 3, 2026 21:38
There was a problem hiding this comment.
Copilot review overview
馃煛 Changes recommended
Asset serving remains untested and valid prefixed entry routing loses Windows coverage.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds integration coverage for virtual URL-prefix routing and documents unsupported runBuild prefix behavior.
Changes:
- Adds bundle, source-map, and invalid-index routing tests.
- Adds expected-failure build tests for filesystem-path semantics.
- Removes private-method unit tests.
| File | Description |
|---|---|
Server-test.js |
Removes direct prefix-resolution tests. |
server-test.js |
Adds HTTP routing integration tests. |
build-test.js |
Documents pending runBuild behavior. |
rambundle-test.js |
Adds prefixed-entry rejection coverage. |
LiteralDir.js |
Provides a literal-prefix fixture. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+133
to
+135
| // TODO(T000000): Fix virtual-prefix URL resolution on Windows. | ||
| // path.sep differences cause entry point resolution to fail. | ||
| (process.platform === 'win32' ? test.skip : test)( |
*Recreating #1706 / [D104259281](https://www.internalfb.com/diff/D104259281) (@motiz88) for GH first without a diff attachment* Adds integration tests for `[metro-project]` and `[metro-watchFolders]` virtual URL prefixes: bundle requests, out-of-bounds index 404, and asset serving. Removes Server unit tests that tested private methods (`_resolveWatchFolderPrefix`, `_getEntryPointAbsolutePath`) directly. The behaviours they covered are now tested end-to-end by the new integration tests and will also be covered by `ProjectRouteMap` unit tests in the next diff. All tests pass without any production code changes. Test plan: See [D104259281](https://www.internalfb.com/diff/D104259281)
facebook-github-tools
Bot
added
the
Shared with Meta
Collaborator
Author
|
Re Copilot, the Windows test gap is closed by #2015, the next in the stack. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreating #1706 / D104259281 (@motiz88) for GH first without a diff attachment
Adds integration tests for
[metro-project]and[metro-watchFolders]virtual URL prefixes: bundle requests, out-of-bounds index 404, and asset serving.Removes Server unit tests that tested private methods (
_resolveWatchFolderPrefix,_getEntryPointAbsolutePath) directly. The behaviours they covered are now tested end-to-end by the new integration tests and will also be covered byProjectRouteMapunit tests in the next diff.All tests pass without any production code changes.
Test plan:
See D104259281