Repository navigation
feat: add fixed-layout typewriter reveals - #3
Merged
Merged
Conversation
Reuse existing progress for discrete native-text visibility while preserving composed effects and the completed token layout. Keep decomposed Hangul clusters and UTF-16 source offsets intact in the grapheme fallback. Update examples, English/Korean documentation, capability gates, declaration checks, and regression coverage.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
typewriter()to reveal text one token at a time while preserving the completed layout. It reusesnativeText(), splitters, timelines, motion, controls, and external progress, and composes with fade/transform effects without another playback owner or per-character React updates.Validation
debuggable=false, Hermes): 62 native assertions / 13 snapshots passed.Behavior and validation limits
progressremains timeline progress, rather than a percentage of visible characters; decreasing it can hide tokens again. Existing stop/play semantics remain unchanged.