ci: run Build workflow on pushes to master - #1224
Merged
Merged
Conversation
The push trigger listed `main`, but this repository's default branch is `master`, so the trigger never fired and nothing validated the default branch after a merge. Every run in the recent history was pull_request triggered. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GWYKHSVSNoLM8Hquum8CuD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The
Buildworkflow'spushtrigger listedmain, but this repository's default branch ismaster. The branch name never matched, so the push trigger has never fired and nothing validates the default branch after a merge.on: push: branches: - - main + - masterThis is observable in the run history: every recent run of
ci.ymlwaspull_request-triggered. The most recent runs attributed tomasterare from 2025 and predate the current configuration. In practice the repo has been relying entirely on pre-merge PR runs, with no post-merge signal on the default branch — so a merge that interacts badly with something else already onmasterwould go unnoticed until the next PR happened to surface it.This also matters for #1223 (automating npm publishing). Any release automation gated on CI wants a trustworthy green signal on the branch it publishes from; right now that signal does not exist.
Test Plan
The change is one word in a workflow trigger and cannot be exercised before merge —
pushtriggers are read from the version of the workflow on the branch being pushed to, so the fix only takes effect once it is onmaster.Verification performed:
masterviagit remote show origin(HEAD branch: master). Creating a PR againstmainfails with a 422base invalid, which is what surfaced this.ci.ymlrun history and confirmed every recent run carries thepull_requestevent, with nopushruns since the trigger was configured.lint,tsc,android, andios(NewArch/OldArch) behave exactly as before. This PR's own checks run via thepull_requesttrigger and exercise the unchanged job definitions.After merge, the next push to
mastershould produce aBuildrun with eventpush— that run is the real confirmation.Generated by Claude Code