fix: prevent track focus from scrolling - #1093
Conversation
|
@nrps9909 is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. Walkthrough本次变更扩展 Changes聚焦滚动控制
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to Track-initiated dragging now focuses the selected handle without scrolling the page, while the public Slider focus path remains unchanged. The change is mergeable with owner awareness that browsers without reliable FocusOptions support may not preserve scroll position consistently. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1093 +/- ##
=======================================
Coverage 98.66% 98.67%
=======================================
Files 15 15
Lines 751 754 +3
Branches 224 226 +2
=======================================
+ Hits 741 744 +3
Misses 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
preventScrollwhen a track press starts a dragFixes #1060.
Verification
focus()received no optionsOverlap audit
I searched current open issues and pull requests for #1060,
preventScroll, and scroll-preserving focus. No implementation overlap was found.AI assistance disclosure: Codex was used to trace the focus path, reproduce the reported behavior at the DOM API boundary, implement the scoped fix and regression, audit overlap, and run validation. The failure and passing results above were verified directly on the exact base and signed head commit.
Summary by CodeRabbit
功能改进
测试