chore(deps-dev): bump the npm-dependencies group across 1 directory with 2 updates - #1084
chore(deps-dev): bump the npm-dependencies group across 1 directory with 2 updates#1084dependabot[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
React Doctor skipped this pull request — it changed no React files. Reviewed by React Doctor for commit |
…ith 2 updates Bumps the npm-dependencies group with 2 updates in the / directory: [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) and [typescript](https://github.com/microsoft/TypeScript). Updates `@testing-library/jest-dom` from 6.10.0 to 7.0.0 - [Release notes](https://github.com/testing-library/jest-dom/releases) - [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md) - [Commits](testing-library/jest-dom@v6.10.0...v7.0.0) Updates `typescript` from 6.0.3 to 7.0.2 - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](https://github.com/microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: "@testing-library/jest-dom" dependency-version: 7.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm-dependencies - dependency-name: typescript dependency-version: 7.0.2 dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
652a7aa to
4f66c2c
Compare
nrps9909
left a comment
There was a problem hiding this comment.
Reviewed exact head 4f66c2c against base 9982e48.
Blocking issue: grouping TypeScript 7.0.2 with the jest-dom update makes the repository lint unable to start. The exact merge workflow fails before source lint with: typescript-eslint does not support TS 7.0. A clean local install on the exact PR head also fails inside @typescript-eslint/type-utils while reading a TypeScript flag that is no longer present.
Causal isolate: I kept @testing-library/jest-dom 7.0.1 and replaced only the installed TypeScript version with 6.0.3. With that single change, npm run lint and npm run tsc passed; the full test suite passed 5/5 suites, 119/119 tests, and 5/5 snapshots; npm run compile also passed for ESM, CJS, declarations, and Less.
Please split or retain the jest-dom update, and defer TypeScript 7 until the typescript-eslint toolchain supports it. The separate Vercel deployment failure is not the basis for this review.
AI assistance disclosure: Codex was used to inspect the exact PR head and CI logs, run the version-isolation matrix, and draft this review. I verified the commands and results before submitting.
Bumps the npm-dependencies group with 2 updates in the / directory: @testing-library/jest-dom and typescript.
Updates
@testing-library/jest-domfrom 6.10.0 to 7.0.0Release notes
Sourced from @testing-library/jest-dom's releases.
Commits
1e39089feat: add toContainAnyBy* and toContainOneBy* query matchersMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for
@testing-library/jest-domsince your current version.Updates
typescriptfrom 6.0.3 to 7.0.2Commits
Maintainer changes
This version was pushed to npm by microsoft1es, a new releaser for typescript since your current version.