fix: set option list virtual prefix#1241
Conversation
|
@QDyanbing is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (4)
WalkthroughOptionList 为虚拟下拉列表新增 Changes下拉列表类名前缀
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the OptionList component to pass a custom prefixCls (${prefixCls}-dropdown-list) to the underlying List component. This changes the generated class names of the dropdown list from rc-virtual-list to rc-select-dropdown-list. Corresponding test assertions and snapshots have been updated to reflect this class name change. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1241 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 31 31
Lines 1271 1271
Branches 466 466
=======================================
Hits 1264 1264
Misses 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
这个改动解决什么?
为 Select 的 OptionList 中的 VirtualList 设置
prefixCls={${prefixCls}-dropdown-list},使下拉虚拟列表及滚动条生成 Select 自身前缀类名,例如rc-select-dropdown-list-scrollbar,便于上层组件按 Select 语义样式精确覆盖。具体改动
验证
npm test -- tests/OptionList.test.tsx tests/Select.test.tsx tests/Accessibility.test.tsx tests/Tags.test.tsx --runInBandSummary by CodeRabbit
样式与可访问性
测试