Skip to content

fix: support RTL layout and navigation - #46

Merged
rdlabo merged 1 commit into
mainfrom
fix/rtl-logical-properties
Sep 16, 2026
Merged

rdlabo merged 1 commit into
mainfrom
fix/rtl-logical-properties

Conversation

@rdlabo

@rdlabo rdlabo commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • use logical spacing for list headers and toolbar slots
  • mirror range knob offsets, endpoint radii, margins, and positioning
  • mirror Material forward/back navigation animations in RTL
  • update demo-only physical spacing and safe-area handling

Depends on rdlabo-dev/ionic-theme-utils#2.
Related to rdlabo-dev/ionic-theme-ios27#168.

Verification

  • npm ci
  • npm run build
  • npm run lint

Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment on lines +7 to +8
const isRTL = opts.enteringEl.ownerDocument.dir === 'rtl';
const OFF_END = isRTL ? -40 : 40;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 要素単位の RTL と遷移方向の不一致

dir="rtl"ion-app などに設定されると、:dir(rtl) は反映されても遷移は LTR のままです。文書ルート限定の RTL 契約か確認してください。

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Playwright test results

passed  82 passed

Details

stats  82 tests across 2 suites
duration  1 minute, 37 seconds
commit  4918d4a
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-46/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@rdlabo
rdlabo force-pushed the fix/rtl-logical-properties branch from 82972a8 to 23547d8 Compare September 16, 2026 00:49
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-46/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@rdlabo
rdlabo force-pushed the fix/rtl-logical-properties branch 2 times, most recently from c5ce4fa to 7c06c2c Compare September 16, 2026 00:59
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-46/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-46/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@rdlabo
rdlabo force-pushed the fix/rtl-logical-properties branch from 7c06c2c to 94ec733 Compare September 16, 2026 01:08
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-46/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@rdlabo
rdlabo force-pushed the fix/rtl-logical-properties branch from 94ec733 to 4918d4a Compare September 16, 2026 01:19
github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-46/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

@rdlabo
rdlabo merged commit a2ce282 into main Sep 16, 2026
11 checks passed
@rdlabo
rdlabo deleted the fix/rtl-logical-properties branch September 16, 2026 01:26
@github-actions

Copy link
Copy Markdown
Contributor

npm beta published

CI passed for the merge commit a2ce2820f0bd. Install the immutable version with:

npm install @rdlabo/ionic-theme-md3@9.1.1-beta.pr46.shaa2ce2820f0bd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant