Skip to content

build(ios26): resolve ESM imports during compilation - #236

Merged
rdlabo merged 1 commit into
ios26from
fix/ios26-build-esm-output
Sep 28, 2026
Merged

rdlabo merged 1 commit into
ios26from
fix/ios26-build-esm-output

Conversation

@rdlabo

@rdlabo rdlabo commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

The iOS 26 theme's emitted ESM contained extensionless imports, so direct Node imports could fail. Keep TypeScript source imports extensionless, matching Ionic's source style, and resolve them automatically during the normal build.

  • Use @rdlabo/ionic-theme-utils@0.1.2 for the shared rdlabo-build-theme and rdlabo-check-esm CLIs.
  • Retain tsc --noEmit for type checking and use tsdown to emit ESM JavaScript and declarations with resolved relative specifiers. Source files are unchanged; dependencies stay external and CSS output is preserved.
  • Declare "type": "module", use TypeScript's bundler resolution mode, and rename the CommonJS Prettier configuration to .cjs.
  • Add packed ESM and declaration checks to CI and document the shared build commands.

This follows the build-time approach discussed in #222. Shared tooling: rdlabo-dev/ionic-theme-utils#5.

Validation on Node 24.17.0:

  • Full package build and formatting checks.
  • npm tarball imports and relative JavaScript/declaration references.
  • NodeNext consumer type checking without skipLibCheck.
  • Angular demo production build and lint.
  • Demo unit tests: 37 passed.

Browser visual and native-device tests were not run locally for this build change.


Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Playwright test results

passed  182 passed

Details

stats  182 tests across 14 suites
duration  2 minutes, 7 seconds
commit  abfd1fa
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-236/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-236/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

@rdlabo
rdlabo merged commit 299a88f into ios26 Sep 28, 2026
18 of 22 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-236/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant