fix: refresh native controls after foreground and viewport changes - #233
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| await page.waitForTimeout(750); | ||
| const previous = await page.evaluate((event) => { | ||
| const snapshot = Capacitor.registerPlugin<ShellMock>('IonicNativeUIShell').updates.at(-1)!; | ||
| if (event === 'foreground') document.dispatchEvent(new Event('visibilitychange')); |
There was a problem hiding this comment.
🔍 前景復帰テストは非表示期間を再現しない
表示中の document に visibilitychange を送るため、非表示時の検索終了と復帰後の表示回復は通らない。実機のバックグラウンド復帰も確認したい。
Was this helpful? React with 👍 or 👎 to provide feedback.
| else if (event === 'window-resize') window.dispatchEvent(new Event('resize')); | ||
| else window.visualViewport!.dispatchEvent(new Event('resize')); |
There was a problem hiding this comment.
🔍 リサイズテストは寸法を変えない
resize イベントのみを送るため、寸法変更後の再測定やネイティブ配置は検証できない。回転・折りたたみ時の実寸法で確認したい。
Was this helpful? React with 👍 or 👎 to provide feedback.
Playwright test results
Details
|
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-233/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-ios27@1.2.0-beta.pr233.sha647eef34274b |
1 participant
Native controls can remain hidden after foregrounding or a viewport change when their control snapshot is unchanged: those events scheduled a measurement, but snapshot deduplication skipped the native update. Force a refresh on visibility restoration and window/visual-viewport resize, using the existing RAF and pending-update handling. Reset transient native rejections through the same refresh path.
The change is limited to the runtime and three regression cases. Each new case fails against the original implementation and passes with the fix. The exact reported iPhone Duo fold/foreground/portrait sequence has not yet been reproduced through CLI, so resolution of that full sequence remains unconfirmed.
Validation: