-
-
Notifications
You must be signed in to change notification settings - Fork 8
fix: restore mode-specific projection when native rail is unavailable #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rdlabo
merged 2 commits into
refactor/foldable-device-state
from
fix/native-edge-null-projection
Sep 28, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 ネイティブレール不在時にクラス操作でモードを解除できない
通常モードで nativeEdge が null の間、有効化クラスは消え、退避属性だけが残ります。アプリがクラスを外しても無効化できず、レール復帰時に意図せず再有効化されます。
Learn more
アプリは
ion-appの.ios-theme-vertical-barsクラスでもレールを有効化できます。説明 にもこの方法が示されています。通常モードでnativeEdge: nullを受けると、監視処理がクラスを外して退避属性だけで要求を保持します。この状態でアプリがclassList.remove('ios-theme-vertical-bars')を呼んでもクラスは既になく、監視処理には解除が伝わりません。その後エッジが復帰すると、残った退避属性を要求と見なしてレールが再有効化されます。Example:
ion-appにクラスを付けていたアプリが、レール不在時に設定画面からclassList.remove('ios-theme-vertical-bars')を実行します。表示は変わらず退避属性が残り、次のエッジ通知でレールが戻ります。期待されるのはモードの解除です。Recommended fix: 要求状態と実効クラスを分離し、公開したクラス操作でも解除を検出できる状態管理にしてください。クラスが既にない状態での
classList.removeは MutationObserver で検出できないため、クラスを常に要求の目印として維持できる CSS 制御、または要求を変更する明示的 API への契約変更を検討してください。Was this helpful? React with 👍 or 👎 to provide feedback.