docs: remove automatic toolbar searchbar class from opt-ins - #231
Merged
Merged
Conversation
Contributor
Playwright test resultsDetails
|
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-231/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
Contributor
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-ios27@1.2.0-beta.pr231.sha22a35d481cf3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Special markup and classes guide incorrectly instructs users to add
.toolbar-searchbar. Ionic adds this class automatically whenion-searchbaremits its style notification.Remove the misleading opt-in section and regenerate the demo documentation.
Validation:
npm --prefix demo run docs:generateandgit diff --checkpassed.