Skip to content

docs: remove automatic toolbar searchbar class from opt-ins - #231

Merged
rdlabo merged 2 commits into
mainfrom
docs/remove-toolbar-searchbar-opt-in
Sep 27, 2026
Merged

rdlabo merged 2 commits into
mainfrom
docs/remove-toolbar-searchbar-opt-in

Conversation

@rdlabo

@rdlabo rdlabo commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

The Special markup and classes guide incorrectly instructs users to add .toolbar-searchbar. Ionic adds this class automatically when ion-searchbar emits its style notification.

Remove the misleading opt-in section and regenerate the demo documentation.

Validation: npm --prefix demo run docs:generate and git diff --check passed.


Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Playwright test results

passed  363 passed

Details

stats  363 tests across 20 suites
duration  4 minutes, 45 seconds
commit  2f245a3
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

github-actions Bot added a commit that referenced this pull request Sep 27, 2026
github-actions Bot added a commit that referenced this pull request Sep 27, 2026
@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-231/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 27, 2026
@rdlabo
rdlabo merged commit 22a35d4 into main Sep 27, 2026
11 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

npm beta published

CI passed for the merge commit 22a35d481cf3. Install the immutable version with:

npm install @rdlabo/ionic-theme-ios27@1.2.0-beta.pr231.sha22a35d481cf3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant