refactor: delegate device state to capacitor-foldable - #230
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Playwright test results
Details
|
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-230/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
rdlabo
force-pushed
the
refactor/foldable-device-state
branch
from
September 28, 2026 00:39
03d687d to
0b4c27f
Compare
Contributor
npm beta publishedCI passed for the merge commit npm install @rdlabo/ionic-theme-ios27@1.2.0-beta.pr230.shac8f41fd85378 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move device-state ownership to the application using
@erkamyaman/capacitor-foldable. Remove the bundled device-layout APIs and native observers, migrate the demo, and document installation and listener lifecycle. Keep WebView corner-radius metrics in the rendering plugin.Applications pass their chosen
edgeand Foldable’s reportednativeEdgeto the theme. When the edges differ, controls use the Web rail and return to native rendering when they match. The theme does not read UIKit bar-placement traits. The demo shares the same placement module between startup and its mode toggle.Breaking change:
DeviceLayout,HingeStatus,getDeviceLayout,startDeviceLayoutMonitoring,stopDeviceLayoutMonitoring, anddeviceLayoutChangeare removed. Consumers must migrate to the documented Foldable APIs.Validation