Skip to content

fix: preserve RTL inset item detail spacing - #211

Merged
rdlabo merged 1 commit into
mainfrom
fix/rtl-inset-item-spacing
Sep 21, 2026
Merged

rdlabo merged 1 commit into
mainfrom
fix/rtl-inset-item-spacing

Conversation

@rdlabo

@rdlabo rdlabo commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • preserve the existing physical-right inset item padding in RTL
  • add the matching physical-left padding for RTL detail icons
  • keep physical safe-area variables mapped to their corresponding physical sides

Verification

  • npm run build:css
  • npm run lint
  • visually verified on the iPhone Duo safe-area fixture: the left detail icon and right text both retain 18px inner spacing

Extracted from #209 so the RTL item correction can be reviewed and released independently.


Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Playwright test results

passed  336 passed

Details

stats  336 tests across 18 suites
duration  4 minutes, 32 seconds
commit  fe39aa9
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

github-actions Bot added a commit that referenced this pull request Sep 21, 2026
@rdlabo
rdlabo merged commit aa0bb42 into main Sep 21, 2026
15 of 20 checks passed
@rdlabo
rdlabo deleted the fix/rtl-inset-item-spacing branch September 21, 2026 11:17
@github-actions

Copy link
Copy Markdown
Contributor

npm beta published

CI passed for the merge commit aa0bb42960d9. Install the immutable version with:

npm install @rdlabo/ionic-theme-ios27@1.0.4-beta.pr211.shaaa0bb42960d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant