Skip to content

fix(ios26): support RTL layout - #176

Merged
rdlabo merged 1 commit into
ios26from
fix/rtl-logical-properties-ios26
Sep 16, 2026
Merged

rdlabo merged 1 commit into
ios26from
fix/rtl-logical-properties-ios26

Conversation

@rdlabo

@rdlabo rdlabo commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • apply the RTL logical-property fixes to the ios26 branch
  • mirror safe-area-aware list, menu, FAB, tab bar, searchbar, toolbar, and button layout
  • update demo-only physical spacing while preserving physical visual effects

Depends on rdlabo-dev/ionic-theme-utils#2.
Related to #168.

Verification

  • npm ci
  • npm run build
  • npm run lint

Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Playwright test results

passed  149 passed

Details

stats  149 tests across 11 suites
duration  1 minute, 46 seconds
commit  d6ff3e9
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-176/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-176/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

@rdlabo
rdlabo force-pushed the fix/rtl-logical-properties-ios26 branch 3 times, most recently from 5bc18f9 to 5ad852b Compare September 16, 2026 00:56
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-176/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@rdlabo
rdlabo force-pushed the fix/rtl-logical-properties-ios26 branch from 5ad852b to e004a1f Compare September 16, 2026 01:00
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-176/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-176/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@rdlabo
rdlabo force-pushed the fix/rtl-logical-properties-ios26 branch from e004a1f to c6c62cd Compare September 16, 2026 01:08
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-176/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@rdlabo
rdlabo force-pushed the fix/rtl-logical-properties-ios26 branch from c6c62cd to d6ff3e9 Compare September 16, 2026 01:19
github-actions Bot added a commit that referenced this pull request Sep 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-176/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

@rdlabo
rdlabo merged commit bbdc0b9 into ios26 Sep 16, 2026
8 checks passed
@rdlabo
rdlabo deleted the fix/rtl-logical-properties-ios26 branch September 16, 2026 01:26
@github-actions

Copy link
Copy Markdown
Contributor

npm beta published

CI passed for the merge commit bbdc0b97d5f8. Install the immutable version with:

npm install @rdlabo/ionic-theme-ios26@9.2.0-beta.pr176.shabbdc0b97d5f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant