docs: RFC 0001 for declarative management of platform resources#1751
docs: RFC 0001 for declarative management of platform resources#1751rohilsurana wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe RFC documents a declarative YAML workflow for reconciling and exporting Frontier resources, defines shared kind behavior and rules for ChangesDeclarative reconciliation design
Estimated code review effort: 2 (Simple) | ~15 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 5
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d8fb691c-6b4f-4ac9-9f5e-4c8db0d04f33
📒 Files selected for processing (1)
docs/rfcs/0001-declarative-reconcile.md
Coverage Report for CI Build 29749206689Coverage remained the same at 46.11%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
rohilsurana
left a comment
There was a problem hiding this comment.
Verified the narrowing warning against the schema and against a live server (built from #1737, seeded an org, narrowed app_organization_owner via reconcile). One sentence in it is factually wrong; details inline. More comments on the other sections will follow.
rohilsurana
left a comment
There was a problem hiding this comment.
Follow-up comments on the remaining sections, per review discussion.
Review notes (self-review after an independent pass)Three wording fixes, all in 3ce4741:
No behavior contradictions found between the RFC and the code on the implementation branch. |
4804038 to
dea97a7
Compare
Documents a declarative way to manage Frontier's platform configuration: desired-state YAML files, the
frontier reconcileandfrontier exportcommands, and the five rules every resource kind follows.TLDR
frontier reconcile -f file --dry-runprints the plan; the same command without the flag applies it.frontier export <kind>prints the live state in the same format, so a file is seeded from a running server.apiVersion: v1(absent means v1). Content with nokind, an unknown kind, or a missing spec is rejected; writespec: []to mean an empty list. The whole file is checked before anything applies, and documents then apply in the order they appear.delete: true. A value always exists and has a default: a value the file leaves out goes back to its default, and there is no delete flag. One field rule covers both. A field you write is the whole value. A field you leave out takes the default. An empty field (""or[]) means empty. Nothing merges.resources_config_pathis deprecated and removed two minor versions later. The reconcile image must match the server release, because the reset target for predefined roles is compiled into the CLI.-Hpasses the token for now and is masked in logs.What it covers
resources_config_path.Status
The RFC is marked Accepted, and the flow is implemented in the
reconcilepackage and thereconcileandexportcommands. PlatformUser, Permission, Role, and Preference are merged tomain; the Webhook kind is in review (#1772). This document describes the shipped design.