Skip to content

fix: stack sidebar footer as a row in production builds #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsbh merged 1 commit into from
Sep 1, 2026
Merged

fix: stack sidebar footer as a row in production builds #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions packages/chronicle/src/themes/default/Layout.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,11 @@
color: var(--rs-color-foreground-base-primary);
}

/* Apsara's Sidebar.Footer is a column Flex — force a row so the version
switcher and links menu sit at opposite ends. */
/* Row layout (direction/align/justify) is set via Sidebar.Footer's Flex props,
not here. Apsara's utility classes and this module have equal specificity, so
overriding from CSS would depend on stylesheet order — which differs between
dev and the production bundle, and silently loses in prod. */
.sidebarFooter {
display: flex;
flex-direction: row;
align-items: center;
justify-content: space-between;
gap: var(--rs-space-3);
height: var(--navbar-height);
box-sizing: border-box;
Expand Down Expand Up @@ -345,6 +343,25 @@
border-top: 0.5px solid var(--rs-color-border-base-primary);
}

/* With no `versions` configured, VersionSwitcher renders `latest.label` as a
bare <span>. Left as-is it reads as loose text under the full-width link
rows, so match Sidebar.Item's metrics and make it a proper footer row. The
versioned case renders a <button> and keeps Apsara's Button styling.

Scoped from the parent rather than inside VersionSwitcher so the desktop
footer keeps its inline treatment. The element+class selector also outranks
Apsara's single-class rules, so this does not depend on stylesheet order. */
.mobileMenuFooter > span {
display: flex;
box-sizing: border-box;
align-self: stretch;
align-items: center;
min-height: var(--rs-space-9);
padding: var(--rs-space-3);
border-radius: var(--rs-radius-2);
color: var(--rs-color-foreground-base-secondary);
}

.mobileNav {
display: none;
}
Expand Down
7 changes: 6 additions & 1 deletion packages/chronicle/src/themes/default/Layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,12 @@ export function Layout({
))}
</Sidebar.Main>
{showFooter ? (
<Sidebar.Footer className={styles.sidebarFooter}>
<Sidebar.Footer
className={styles.sidebarFooter}
direction='row'
align='center'
justify='between'
>
<VersionSwitcher />
<SidebarLinks />
</Sidebar.Footer>
Expand Down
Loading