Repository navigation
Conversation
IsWindowResized() was true after SetWindowSize() only on the SDL backend, which posts a resize event. GLFW, Win32, RGFW, and the web backend never set the flag from the call itself. Mark the window as resized when the requested size actually changes, so all backends agree. Fixes raysan5#6333
kevin9327
force-pushed
the
fix-setwindowsize-resized
branch
from
November 12, 2026 03:18
97c8e93 to
4b79fa2
Compare
Contributor
|
Does this actually fix the issue? |
Contributor
|
Looking at the changes in this PR, if you called However, I don't think it actually fixes the difference between |
Owner
|
@kevin9327 thanks for the review but I don't know if it is the right approach, I need to review it more carefully, I feel it should be set on an underlying layer, not in that function... |
IsWindowResized() after SetWindowSize() on every backend
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsWindowResized()returned true afterSetWindowSize()only on the SDL backend, which posts a window-resize event. On GLFW, Win32, RGFW, and web it stayed false, even though the window size had changed.This sets
CORE.Window.resizedLastFrameinSetWindowSize()on those backends (and on SDL as well, so the flag is not delayed until the next event poll) when the requested size differs from the current one.That matches the intended behavior from #6333:
IsWindowResized()should also reflect a resize made throughSetWindowSize(), and every backend should do the same thing.Fixes #6333