Repository navigation
[examples] Clarify srcrec_dstrec examples - #6401
Merged
Merged
Conversation
It wasn't obvious why scarfy width was divided by 6 @ line 34 In addition, it is confusing to use the unscaled texture to get it's center point when it's supposed to be relative to the destination rectangle, so I changed it to use the destination rectangle members instead
Owner
|
@Etevoldo thanks for the review, I'm re-reviewing it on my side to better clarify some parts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It wasn't obvious why scarfy width was divided by 6 @ line 34
In addition, it is confusing to use the unscaled texture to get it's center point when it's supposed to be relative to the destination rectangle, so I changed it to use the destination rectangle members instead