Run the specification closure once: single-pass recording replaces the probe (0.12.0) - #143
Merged
Merged
Conversation
…e probe Since 0.11.0 the recording ended on the first double call and re-ran the closure through Runtime::probe() to see whether a second call hid in the arguments of the first. The closure is user code, so every side effect in it happened twice: a counter went up twice, a factory built twice, an Understudy::for() inside it created a second double that stayed in the context and failed verifyAll(strictStubs: true) as a stub never used. The recording now keeps going past a call: the dispatcher retains the signal and answers the call with the mode's type-safe default out of a throwaway context, so every call the closure makes is seen in one pass and more than one is refused. A method with no safe default (never, an object type) still ends the closure on its signal. Code after the call runs against the default, and where it does not survive it the specification stands — that code was never run before and is not the specification. Two calls side by side are refused like a nested pair, and the refusal reads the same for both shapes; nestedCall() is moreThanOneCall(). Fixes #142
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #142
Since 0.11.0 the recording ended on the first double call and re-ran the closure through
Runtime::probe()to see whether a second call hid in the arguments of the first. The closure is user code, so every side effect in it happened twice: a counter went up twice, a factory built twice, anUnderstudy::for()inside it created a second double that stayed in the context and failedverifyAll(strictStubs: true)as a stub never used.The recording now keeps going past a call: the dispatcher retains the signal and answers the call with the mode's type-safe default out of a throwaway context, so every call the closure makes is seen in one pass and more than one is refused. A method with no safe default (
never, an object type) still ends the closure on its signal. Code after the call runs against the default, and where it does not survive it the specification stands — that code was never run before and is not the specification.Two calls side by side are refused like a nested pair, and the refusal reads the same for both shapes;
InvalidCallSpecification::nestedCall()ismoreThanOneCall()— the one BC break, declared by the0.12.0heading.composer build: 1113 tests greenbin/package-audit: cleanFound by the 2026-09-19 family review (H-1).