fix(devkit): remove SC2034 dead variable assignments - #118
Open
t0kubetsu wants to merge 1 commit into
Open
Conversation
Remove DEFAULT_OUTPUT_JSON/OUTPUT_JSON mechanism in proxmox_vm.vm_id.get_usage.to.jsons.sh (--json/--text output modes were a planned TODO never implemented; OUTPUT_JSON was never read). Remove SIMPLE_TYPE and SIMPLE_VALUE dead local declarations in devkit_proxmox.STDIN.normalize.to.jsons.sh (code re-checks STDIN_DATA directly via regex at the usage sites).
2 tasks
t0kubetsu
added a commit
that referenced
this pull request
Aug 11, 2026
The production-profile ansible-lint job answered pparage's review question the hard way: despite the repo name, the tree holds only shell scripts, ansible.cfg variants, Python callback plugins and JSON examples — the only YAML is .github/ itself. A lint gate for absent tech is noise; re-add with profile basic + .ansible-lint (like the sibling repos) if roles or playbooks ever land here. ShellCheck gate verified locally (shellcheck 0.11.0, --severity=warning, all 106 scripts): only failures are the 3 SC2034 dead variables already fixed by PR #118 — merge #118 first.
t0kubetsu
added a commit
that referenced
this pull request
Aug 11, 2026
… scripts (SC2034) Their jq output hardcodes action: "vm_list" — the variable was never wired in, unlike the other _with_api scripts which pass --arg action "$ACTION". Same dead-var removal approach as #118. Verified: shellcheck --severity=warning green across the whole tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117
Summary
Remove ShellCheck SC2034 dead variable assignments from two scripts.
devkit_proxmox.STDIN.normalize.to.jsons.sh: dropSIMPLE_VALUE/SIMPLE_TYPElocal declarations and theif/elifblock that assigned them — neither variable is ever read; the call sites re-checkSTDIN_DATAdirectly.proxmox_vm.vm_id.get_usage.to.jsons.sh: dropDEFAULT_OUTPUT_JSONTODO placeholder,OUTPUT_JSONderivation, and the--json/--textwrite-only assignments —OUTPUT_JSONwas never consumed downstream.No behaviour change. Source files only — no CI config touched.
Commits
22494e0 fix(devkit): remove SC2034 dead variable assignments