Bump wgpu, winit, and other Rust deps to latest - #6
Open
randspace0 wants to merge 2 commits into
Open
Conversation
wgpu 0.17->30, winit 0.28->0.30, pollster 0.3->1.0, log 0.4->0.4.33, android_logger 0.13->0.15. winit 0.30 replaces the run_return/Event match loop with the ApplicationHandler trait, so app.rs is restructured around resumed/window_event/suspended. wgpu 30 changes surface creation (now Arc<Window>-based and safe), request_device (single descriptor with required_features/required_limits), render pass Operations.store (now StoreOp), and several other struct field renames. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AGMMuyCZW4y3wPdjr8WxnC
AGP 8.2.1 -> 8.13.2 (latest version compatible with rust-android-gradle; AGP 9.x is blocked by an open upstream issue - mozilla/rust-android-gradle#172/#168 - the plugin still references the AppExtension type AGP 9's new DSL removes), Kotlin 1.9.0 -> 2.4.10, Gradle wrapper 8.2 -> 8.14.4, rust-android-gradle 0.9.3 -> 0.9.6, compileSdk/targetSdk 34 -> 36, JDK target 1.8 -> 17. Downgraded a few androidx deps that require AGP 9.1+/compileSdk 37 (core-ktx to 1.17.0) or exceed android-activity's documented GameActivity compatibility (games-activity pinned to 4.4.0). Added pythonCommand = "python3" since rust-android-gradle's linker wrapper shells out to a bare `python`, which isn't guaranteed to exist. Also fixes lib/src/lib.rs: winit 0.30 moved EventLoopBuilder::with_user_event() to EventLoop::with_user_event() (missed in the initial wgpu/winit dependency bump). Verified: builds, installs, and renders correctly on a physical arm64-v8a device. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AGMMuyCZW4y3wPdjr8WxnC
Owner
Author
|
Also bumped the Android build tooling in a follow-up commit:
Also caught and fixed a real bug from the initial wgpu/winit bump: Verified end-to-end: built, installed, and ran on a physical arm64-v8a device — the wgpu triangle renders correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wgpu0.17.0 -> 30.0.0winit0.28.6 -> 0.30.13pollster0.3.0 -> 1.0.1log0.4 -> 0.4.33android_logger0.13.3 -> 0.15.1winit 0.30 replaces the
run_return/Eventmatch-loop model with theApplicationHandlertrait, solib/src/app.rsis restructured aroundresumed/window_event/suspended, withWindowEvent::RedrawRequesteddriving the render loop instead of
MainEventsCleared.wgpu 30 brings several breaking API changes handled here: surface
creation is now safe and takes an
Arc<Window>,request_devicetakesa single descriptor with
required_features/required_limits,Operations::storeis nowStoreOpinstead ofbool,SurfaceTexture::presentmoved toQueue::present, and a handful ofstruct fields were renamed (
multiview->multiview_mask,push_constant_ranges->immediate_size, plus new required fieldslike
SurfaceConfiguration::color_space).Test plan
cargo checkpasses on the host target (x86_64-unknown-linux-gnu)cargo check --target aarch64-linux-androidresolves and compilesall Rust code; the only failure is
android-activity's nativeC++ build step, which requires the Android NDK (not installed in
this environment) and is unrelated to the dependency/API changes
./gradlew assembleDebug(needs local NDKsetup, not verified here) — please confirm on-device before merge
🤖 Generated with Claude Code
https://claude.ai/code/session_01AGMMuyCZW4y3wPdjr8WxnC