Skip to content

test: burst_memory waits for the heap to settle before its leak check - #191

Merged
dendisuhubdy merged 1 commit into
mainfrom
fix/burst-memory-settle
Nov 18, 2026
Merged

dendisuhubdy merged 1 commit into
mainfrom
fix/burst-memory-settle

Conversation

@dendisuhubdy

Copy link
Copy Markdown
Member

the_27_oct_burst_costs_a_real_node_a_bounded_heap (OPS-602, #185) failed on the push run of #190 (run 44284862601), a PR that touches no Rust; the pull_request run of the same commit passed.

After each RPC burst the test slept a fixed 500 ms and then required the heap to be back within 16 MiB of the baseline. On that run the 8- and 16-submission bursts left +0.0 MiB, the 24-submission burst +28.0 MiB: its last copies were still being dropped on a loaded runner.

The fix polls every 250 ms until the heap is within the 16 MiB limit or 15 s have passed. The assertion is unchanged, so a real leak still fails.

Ran 5× on a 16-vCPU host while a single-threaded prove held about 48 GB (results in a comment).

🤖 Generated with Claude Code

https://claude.ai/code/session_01YGaYNLS2uLR7w6m2JtejVo

The RPC bursts slept a fixed 500 ms after the answers and then required the
heap to be back within 16 MiB of the baseline. On a loaded runner the last
copies of a burst are still being dropped then: run 44284862601 (PR #190,
which touches no Rust) left 28 MiB after the 24-submission burst, while the
pull_request run of the same commit passed. Poll every 250 ms until the heap is
within the limit or 15 s pass; the assertion is unchanged, so a leak still fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YGaYNLS2uLR7w6m2JtejVo
@dendisuhubdy

Copy link
Copy Markdown
Member Author

Ran cargo test -p randprotocol-node --release --test burst_memory -- --nocapture 5× on a 16-vCPU / 125 GB host, with a single-threaded msauth prove holding ~48 GB alongside: 5/5 passed (8.3–8.5 s each). After each RPC burst (8/16/24) the heap settled to +0.0 MiB; peaks 112–152 MiB against the 160 MiB bound; gossip left +20.1 MiB, the recent-transaction cache, as before.

@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dendisuhubdy
dendisuhubdy merged commit 069aad7 into main Nov 18, 2026
23 checks passed
@dendisuhubdy
dendisuhubdy deleted the fix/burst-memory-settle branch November 18, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant