Repository navigation
test: burst_memory waits for the heap to settle before its leak check - #191
Merged
Merged
Conversation
The RPC bursts slept a fixed 500 ms after the answers and then required the heap to be back within 16 MiB of the baseline. On a loaded runner the last copies of a burst are still being dropped then: run 44284862601 (PR #190, which touches no Rust) left 28 MiB after the 24-submission burst, while the pull_request run of the same commit passed. Poll every 250 ms until the heap is within the limit or 15 s pass; the assertion is unchanged, so a leak still fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YGaYNLS2uLR7w6m2JtejVo
Member
Author
|
Ran |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the_27_oct_burst_costs_a_real_node_a_bounded_heap(OPS-602, #185) failed on the push run of #190 (run 44284862601), a PR that touches no Rust; the pull_request run of the same commit passed.After each RPC burst the test slept a fixed 500 ms and then required the heap to be back within 16 MiB of the baseline. On that run the 8- and 16-submission bursts left +0.0 MiB, the 24-submission burst +28.0 MiB: its last copies were still being dropped on a loaded runner.
The fix polls every 250 ms until the heap is within the 16 MiB limit or 15 s have passed. The assertion is unchanged, so a real leak still fails.
Ran 5× on a 16-vCPU host while a single-threaded prove held about 48 GB (results in a comment).
🤖 Generated with Claude Code
https://claude.ai/code/session_01YGaYNLS2uLR7w6m2JtejVo