Repository navigation
RPC-201: refuse rand_getScanLeaves by default from v0.9.0, by the node's own version - #179
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dendisuhubdy
force-pushed
the
feat/i39-scan-leaves-retirement
branch
4 times, most recently
from
November 18, 2026 19:06
d116837 to
2e999ee
Compare
… node's own version RPC only; no consensus change and no change on a v0.8.x node. The default now follows the release: served before v0.9.0 unless --disable-scan-leaves, refused from v0.9.0 unless the new --enable-scan-leaves (the two together are refused). So the flip the owner decided on 2026-11-05 happens with the version bump. While it serves the method a node logs a warning at its 1st, 2nd, 4th, ... served call since start, the count only, so the journal shows whether wallets before v0.8.3 still scan through it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN
dendisuhubdy
force-pushed
the
feat/i39-scan-leaves-retirement
branch
from
November 18, 2026 19:54
2e999ee to
4fd4ab4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks randprotocol/monorepo#39
State of main
--disable-scan-leavesshipped in v0.8.5, off by default. Owner decision of 2026-11-05: keep serving until v0.9.0, then flip the default. The flip itself, and the--enable-scan-leavesthe docs promised, were not written.What this PR does
--disable-scan-leaves; refused from v0.9.0 unless the new--enable-scan-leaves. The two flags together are refused. No change on a v0.8.x node.docs/rpc.md,docs/cli.md, changelog.Consensus
RPC only; not consensus-visible. Nothing to gate.
Tests
rpc201_scan_leaves_is_refused_by_default_from_v0_9_0(new) and the existing flag test: 2 passed (cargo test -p randprotocol-node --bin rand-node).cargo test -p randprotocol-node --lib scan_leaves: 2 passed (the disabled-method test now also checks the served-call count moves).randprotocol-node, all targets, warnings denied: clean.Residual
--disable-scan-leaves(a deploy action, the owner's call per host).Changelog line
Not in this branch (
CHANGELOG.mdis left as main's); for the follow-up changelog PR, under Unreleased:🤖 Generated with Claude Code
https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN