Skip to content

RPC-201: refuse rand_getScanLeaves by default from v0.9.0, by the node's own version - #179

Merged
dendisuhubdy merged 1 commit into
mainfrom
feat/i39-scan-leaves-retirement
Nov 18, 2026
Merged

dendisuhubdy merged 1 commit into
mainfrom
feat/i39-scan-leaves-retirement

Conversation

@dendisuhubdy

@dendisuhubdy dendisuhubdy commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Tracks randprotocol/monorepo#39

State of main

--disable-scan-leaves shipped in v0.8.5, off by default. Owner decision of 2026-11-05: keep serving until v0.9.0, then flip the default. The flip itself, and the --enable-scan-leaves the docs promised, were not written.

What this PR does

  • The default follows the node's version: served before v0.9.0 unless --disable-scan-leaves; refused from v0.9.0 unless the new --enable-scan-leaves. The two flags together are refused. No change on a v0.8.x node.
  • A serving node logs a warning at its 1st, 2nd, 4th, 8th, … served call since start (count only, no caller), so the journal shows whether wallets before v0.8.3 still scan through it.
  • docs/rpc.md, docs/cli.md, changelog.

Consensus

RPC only; not consensus-visible. Nothing to gate.

Tests

  • rpc201_scan_leaves_is_refused_by_default_from_v0_9_0 (new) and the existing flag test: 2 passed (cargo test -p randprotocol-node --bin rand-node).
  • cargo test -p randprotocol-node --lib scan_leaves: 2 passed (the disabled-method test now also checks the served-call count moves).
  • Clippy on randprotocol-node, all targets, warnings denied: clean.

Residual

  • Nothing changes on chain 21's hosts until v0.9.0 is released and rolled, or a host is started with --disable-scan-leaves (a deploy action, the owner's call per host).
  • The sale proxy's allowlist entry for the method lives in another repository.
  • The log line is a count per process since start; it is not a metric or an RPC field.

Changelog line

Not in this branch (CHANGELOG.md is left as main's); for the follow-up changelog PR, under Unreleased:

- **`rand_getScanLeaves` is refused by default from v0.9.0** (RPC-201; RPC only, no consensus
  change): the default now follows the node's own version — served before v0.9.0 unless
  `--disable-scan-leaves`, refused from v0.9.0 unless the new `--enable-scan-leaves` — so the flip
  the owner decided on 2026-11-05 happens with the version bump. No change on a v0.8.x node. A
  serving node logs a warning at its 1st, 2nd, 4th, … served call (the count only), so the
  journal shows whether wallets before v0.8.3 still scan through it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN

@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dendisuhubdy
dendisuhubdy force-pushed the feat/i39-scan-leaves-retirement branch 4 times, most recently from d116837 to 2e999ee Compare November 18, 2026 19:06
… node's own version

RPC only; no consensus change and no change on a v0.8.x node. The default
now follows the release: served before v0.9.0 unless
--disable-scan-leaves, refused from v0.9.0 unless the new
--enable-scan-leaves (the two together are refused). So the flip the owner
decided on 2026-11-05 happens with the version bump. While it serves the
method a node logs a warning at its 1st, 2nd, 4th, ... served call since
start, the count only, so the journal shows whether wallets before v0.8.3
still scan through it.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN
@dendisuhubdy
dendisuhubdy force-pushed the feat/i39-scan-leaves-retirement branch from 2e999ee to 4fd4ab4 Compare November 18, 2026 19:54
@dendisuhubdy
dendisuhubdy merged commit cffc8af into main Nov 18, 2026
18 of 23 checks passed
@dendisuhubdy
dendisuhubdy deleted the feat/i39-scan-leaves-retirement branch November 18, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant