Repository navigation
MSA-4: --max-multisig-accounts, a per-node cap on pooled CreateMultisig - #176
Merged
Merged
Conversation
dendisuhubdy
force-pushed
the
feat/i36-multisig-create-policy
branch
4 times, most recently
from
November 18, 2026 09:40
2f6e3cd to
98c96f6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Node policy; consensus is unchanged. With the flag set, the pool's pre-screen and its direct insert refuse a CreateMultisig once the multisig register holds that many accounts (MultisigAtNodeCap: Ignore to gossip, not cached), so the node does not verify, pool, relay or propose it. Off by default. For a chain whose genesis sets no multisig.max_accounts: a block carrying a create still applies, so the register is bounded only when every proposer sets the flag. The validity rule stays the genesis field. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN
…ollow-up changelog PR Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN
…sig_account_cap Both tests landed on main (#186, #185) after this branch added the NodeConfig field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN
) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN
dendisuhubdy
force-pushed
the
feat/i36-multisig-create-policy
branch
from
November 18, 2026 19:04
98c96f6 to
6eae671
Compare
dendisuhubdy
added a commit
that referenced
this pull request
Nov 18, 2026
… Unreleased (#192) Each entry is the PR's own "Changelog line" section, which the PRs kept out of CHANGELOG.md so they would not conflict with each other: #173, #174, #176–#180, #183, #185–#188 (#175 is test-only and has none). Claude-Session: https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks randprotocol/monorepo#36
State of main
Genesis
multisig.max_accountsexists since v0.8.2 and is an operator input ofdeploy/cut-chain22-genesis.sh(MULTISIG_MAX_ACCOUNTS, no default). Chain 21's genesis does not set it, so the ledger never refuses a create there.What this PR does
rand-node run --max-multisig-accounts <COUNT>(off by default). Once the multisig register holds that many accounts, the pool's pre-screen and direct insert refuse aCreateMultisig(MultisigAtNodeCap:Ignoreto gossip, not cached, no peer penalised). The node then does not verify, pool, relay or propose it. Other multisig actions are not affected.Consensus
Not consensus-visible; no gate needed.
Ledger::validate/applyare untouched: a block carrying a create applies as on v0.8.6. The validity rule stays genesismultisig.max_accounts.Tests
mempool::tests::msa4_a_create_multisig_past_the_node_cap_is_not_pooledandmsa4_the_multisig_accounts_flag_takes_a_count_and_defaults_to_none(new).cargo test -p randprotocol-node --lib -- msa4_ mempool:: admission::: 119 passed.cargo check -p randprotocol-node --testsand clippy with warnings denied: clean.Residual
MULTISIG_MAX_ACCOUNTSchosen and chain 22 cut.Changelog line
Not in this branch (
CHANGELOG.mdis left as main's); for the follow-up changelog PR, under Unreleased:🤖 Generated with Claude Code
https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN