Skip to content

VK-9: the wallet refuses retired RandProtocol prover keys wherever they come from - #13

Merged
dendisuhubdy merged 1 commit into
mainfrom
feat/i18-retired-prover-keys
Nov 18, 2026
Merged

dendisuhubdy merged 1 commit into
mainfrom
feat/i18-retired-prover-keys

Conversation

@dendisuhubdy

Copy link
Copy Markdown
Member

Tracks randprotocol/monorepo#18 (fullnode side: randprotocol/fullnode#187)

Kind: local (wallet engine and docs). Nothing on the wire changes.

What main already does

  • Wallet 0.8.1+ pins only the live members a and b; the release pipeline holds the shipped pool to its pins.
  • Wallet 0.8.2+ says "Update Rand Wallet" when a pinned member answers with another key.
  • Nothing in the wallet knows which keys were retired: a link naming a retired key can be paired, and a stored pairing with one keeps being used.

What this adds

  • RETIRED_PROVER_KEYS in ui/engine/backend-shared.js: the shared key of 0.6.8 and the four members 0.6.9–0.8.0 pinned, with dates. The same list ships in rand (fullnode#187).
  • The shared engine refuses a listed key at every point a prover is chosen: prover.pair (before any network), prover.probe, the job path for a paired prover (a definite error, before the prover is asked or anything is built), and the pool's member list (a listed member is skipped; the others still work).
  • One new sentence, "This prover's key was retired and is no longer used. Pair another prover in Settings, or update Rand Wallet to the latest version.", in en.js (regenerated) and the 19 other dictionaries. The 19 translations were written by the model from each dictionary's existing wording for prover, key, pair, Settings and update; they have not been reviewed by a speaker.
  • ui/test/no-shared-prover-key.test.mjs lets exactly the retired-list entry shape name the 0.6.8 shared key; every other mention still fails.
  • docs/retired-prover-keys.md: the table, what a released wallet can and cannot do, the notice to publish, and the line for the next release notes. docs/prover.md §8 points at it.

Tests

node --test ui/test/prover.test.mjs ui/test/no-shared-prover-key.test.mjs ui/test/i18n.test.mjs
tests 99, pass 99, fail 0
  the retired pool keys are listed, and the pinned pool names none of them
  a link that names a retired key is not paired, and nothing is asked of it          (with a control: the same link pairs when its key is not listed)
  a pairing stored before its key was retired is sent nothing after the update
  a pool member whose key is on the retired list is never asked; the others still are

node --test "ui/test/**/*.test.mjs"
tests 1137, pass 1136, fail 1

The one failure, rpc-methods.test.mjs "covers exactly the methods the vendored node dispatches", is ENOENT core/vendor/fullnode/…/rpc.rs: the worktree this ran in has no submodule checkout. It does not touch this change; CI has the submodule.

What remains

  • Wallets 0.6.9–0.8.0 still pin the retired keys. No change here or anywhere reaches them; they must be updated. The notice in docs/retired-prover-keys.md is for the owner to publish (release page, site, stores).
  • Android and iOS pair through their own code (ProverPairing.java, ProverPairingService.swift) and are not changed here; the list is enforced in the shared JS engine (extension, web, desktop). Carrying it into the two native shells, or into the Rust core's link parser so every shell inherits it, is still to do.
  • No wallet release is cut by this PR, and no version is bumped.
  • The translations need a reviewer.

🤖 Generated with Claude Code

https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN

…ey come from

A wallet released before a pool key was retired keeps pinning it; nothing can
change that. What every later release can do is carry the list of retired keys
and refuse them. RETIRED_PROVER_KEYS (ui/engine/backend-shared.js) names the
shared key of 0.6.8 and the four members 0.6.9-0.8.0 pinned. A link that names
one is not paired and its prover is not asked; a pairing stored before its key
was retired is sent nothing after the update, and its probe says why; a pinned
pool member whose key is listed is skipped. One new sentence, in all twenty
languages.

docs/retired-prover-keys.md has the table, what a released wallet can and
cannot do, the notice to publish and the release-notes line.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN
@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dendisuhubdy
dendisuhubdy merged commit f3e81b9 into main Nov 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant