Repository navigation
VK-9: the wallet refuses retired RandProtocol prover keys wherever they come from - #13
Merged
Merged
Conversation
…ey come from A wallet released before a pool key was retired keeps pinning it; nothing can change that. What every later release can do is carry the list of retired keys and refuse them. RETIRED_PROVER_KEYS (ui/engine/backend-shared.js) names the shared key of 0.6.8 and the four members 0.6.9-0.8.0 pinned. A link that names one is not paired and its prover is not asked; a pairing stored before its key was retired is sent nothing after the update, and its probe says why; a pinned pool member whose key is listed is skipped. One new sentence, in all twenty languages. docs/retired-prover-keys.md has the table, what a released wallet can and cannot do, the notice to publish and the release-notes line. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks randprotocol/monorepo#18 (fullnode side: randprotocol/fullnode#187)
Kind: local (wallet engine and docs). Nothing on the wire changes.
What main already does
What this adds
RETIRED_PROVER_KEYSinui/engine/backend-shared.js: the shared key of 0.6.8 and the four members 0.6.9–0.8.0 pinned, with dates. The same list ships inrand(fullnode#187).prover.pair(before any network),prover.probe, the job path for a paired prover (a definite error, before the prover is asked or anything is built), and the pool's member list (a listed member is skipped; the others still work).en.js(regenerated) and the 19 other dictionaries. The 19 translations were written by the model from each dictionary's existing wording for prover, key, pair, Settings and update; they have not been reviewed by a speaker.ui/test/no-shared-prover-key.test.mjslets exactly the retired-list entry shape name the 0.6.8 shared key; every other mention still fails.docs/retired-prover-keys.md: the table, what a released wallet can and cannot do, the notice to publish, and the line for the next release notes.docs/prover.md§8 points at it.Tests
The one failure,
rpc-methods.test.mjs"covers exactly the methods the vendored node dispatches", isENOENT core/vendor/fullnode/…/rpc.rs: the worktree this ran in has no submodule checkout. It does not touch this change; CI has the submodule.What remains
docs/retired-prover-keys.mdis for the owner to publish (release page, site, stores).ProverPairing.java,ProverPairingService.swift) and are not changed here; the list is enforced in the shared JS engine (extension, web, desktop). Carrying it into the two native shells, or into the Rust core's link parser so every shell inherits it, is still to do.🤖 Generated with Claude Code
https://claude.ai/code/session_01YGaYNQ4cvFtg2UmokVgrAN