Drop the "cut no release yet" comment on the chain test - #16
Drop the "cut no release yet" comment on the chain test#16thedavidmeister wants to merge 1 commit into
Conversation
`src/generated/0_1_1/{DecimalFloat,LogTables}.sol` are frozen and the
released libs declare `decimal-float@0_1_1` and `log-tables@0_1_1`, so
`releasedSuites()` is not empty and the inherited test has a subject and
forks every supported network. The comment said the opposite.
Deleted rather than corrected: naming 0_1_1 re-arms the same trap at the
next release, and nothing expires a comment. The sibling sentence stays
because it is durable — `LibDecimalFloatDeployProdTest` checks the live
CURRENT pins, which is a different claim from a release that already
happened.
Closes #14
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe contract-level documentation comment no longer states that no frozen release exists or that the inherited test is inactive. It retains the explanation of the live CURRENT pins check. ChangesDeployment test documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change only removes stale explanatory text from a test file and does not alter test behavior or production code. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DecimalFloatDeployChainTest's comment said this repo has cut no release underthe frozen-record model, so
releasedSuites()is empty and the inherited testhas no subject and forks nothing.
It has a subject.
src/generated/0_1_1/DecimalFloat.solandsrc/generated/0_1_1/LogTables.solare frozen on main,LibDecimalFloatReleaseddeclaresdecimal-float@0_1_1andLibLogTablesReleaseddeclareslog-tables@0_1_1, soreleasedSuites()returns those and the chain group forks every supported network against them.
A reader is told the test is inert when it is the opposite.
Deleted rather than corrected, per the ruling on rainlanguage/rain.deploy#153:
naming 0_1_1 re-arms the same trap, because the next release falsifies it again
and nothing expires a comment.
Only the transient half goes — that this repo has released nothing, that
releasedSuites()is therefore empty, and that it gains a subject when thefirst
src/generated/<tag>/lands. The sibling sentence is durable and staysverbatim:
LibDecimalFloatDeployProdTestchecks the live CURRENT pins, which isa different claim, because the candidate is what the NEXT release will be and a
released suite is a deployment that already happened. Nothing in the file shows
that, and no release can falsify it. The remaining lines are a rewrap of words
already there; no replacement prose was added.
QA
git diff: every changed line is a///line above the contract, and the two lines that appear as additions are the surviving sentence rewrapped after the words in front of it were cut.src/generated/0_1_1/DecimalFloat.solandsrc/generated/0_1_1/LogTables.solexist on main, andsrc/lib/LibDecimalFloatReleased.sol/src/lib/LibLogTablesReleased.solemitsuite: "decimal-float@0_1_1"andsuite: "log-tables@0_1_1"intoreleasedSuites()viaLibReleasedSuites. That is what makes the deleted sentences false, read from the frozen record and the generated libs rather than from any prose. The retained sentence was checked too:LibDecimalFloatDeployProdTestexists, attest/src/lib/deploy/LibDecimalFloatDeployProd.t.sol.test/src/abstract/DecimalFloatDeployChain.t.sol. Also grepped this repo for the same class of claim ("cut no release", "released none", "has released", "no subject") and this file held the only occurrence.Closes #14
Summary by CodeRabbit