Rename the Git is clean job id to git-clean - #30
Merged
Conversation
Closes #27 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27
The org's currency check has one file name, one workflow name and three job ids. #27 standardises on
git-clean. This repo needed the job id only —.github/workflows/git-clean.yamlalready carriedname: Git is clean.The job id is the first segment of what renders in the checks list. On
mainthe context iscopy-artifacts / copy-artifacts; on this PR it isgit-clean / copy-artifacts. The trailing segment is the job id inside rainix'srainix-copy-artifacts.yamland the issue puts that out of scope. The two repos the issue calls fully conformant (rain.solver, rain.uniswap) render a baregit-cleanonly because they inline the steps instead of calling the reusable, so collapsing this to one segment would be a rainix-side change, not a consumer-side one.Not renamed:
uses: rainlanguage/rainix/.github/workflows/rainix-copy-artifacts.yaml@main. rainix defines that reusable rather than consuming it; renaming it would break every consumer'suses:line.Branch protection: checked before renaming.
mainis unprotected here (branches/main/protectionreturns 404) and no ruleset applies to it (rules/branches/mainreturns[]). Nothing required thecopy-artifactscontext, so this rename does not silently stop a required check being required. No protection change is needed and none was made.QA
git-clean, which is the assertion the issue makes..github/workflows/git-clean.yaml, workflowname: Git is clean, job idgit-clean), plus GitHub's own rendering of the job id in this PR's checks list and the GitHub API's branch-protection and rules responses formain.mainbefore changing anything, this repo already had the file name and the workflow name, and the job id wascopy-artifacts; that job id is what this PR changes, so all three are covered. The issue's precondition — check branch protection for a requiredcopy-artifactscontext before renaming — was carried out and its result is recorded above.