Skip to content

Rename the Git is clean job id to git-clean - #30

Merged
thedavidmeister merged 1 commit into
mainfrom
27-git-clean-job-id
Aug 27, 2026
Merged

Rename the Git is clean job id to git-clean#30
thedavidmeister merged 1 commit into
mainfrom
27-git-clean-job-id

Conversation

@thedavidmeister

@thedavidmeister thedavidmeister commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Closes #27

The org's currency check has one file name, one workflow name and three job ids. #27 standardises on git-clean. This repo needed the job id only.github/workflows/git-clean.yaml already carried name: Git is clean.

 jobs:
-  copy-artifacts:
+  git-clean:

The job id is the first segment of what renders in the checks list. On main the context is copy-artifacts / copy-artifacts; on this PR it is git-clean / copy-artifacts. The trailing segment is the job id inside rainix's rainix-copy-artifacts.yaml and the issue puts that out of scope. The two repos the issue calls fully conformant (rain.solver, rain.uniswap) render a bare git-clean only because they inline the steps instead of calling the reusable, so collapsing this to one segment would be a rainix-side change, not a consumer-side one.

Not renamed: uses: rainlanguage/rainix/.github/workflows/rainix-copy-artifacts.yaml@main. rainix defines that reusable rather than consuming it; renaming it would break every consumer's uses: line.

Branch protection: checked before renaming. main is unprotected here (branches/main/protection returns 404) and no ruleset applies to it (rules/branches/main returns []). Nothing required the copy-artifacts context, so this rename does not silently stop a required check being required. No protection change is needed and none was made.

QA

  • Discriminating tests: n/a — the diff changes a GitHub Actions job id (and, where present, prose naming that id). No test in this repo reads a workflow job id, so no test can discriminate. The discriminator is this PR's own checks list: it renders the job as git-clean, which is the assertion the issue makes.
  • Mutations applied: n/a — nothing executable changed. The YAML key is consumed by GitHub Actions, not by the repo's build or test code, and the doc/NatSpec edits are comments; there is no line a mutation could survive in.
  • Oracle: Standardise the currency check on git-clean (file, workflow name and job id) #27, which states the target triple independently of this diff (file .github/workflows/git-clean.yaml, workflow name: Git is clean, job id git-clean), plus GitHub's own rendering of the job id in this PR's checks list and the GitHub API's branch-protection and rules responses for main.
  • Category check: the issue asks for three things — file name, workflow name, job id. Read on main before changing anything, this repo already had the file name and the workflow name, and the job id was copy-artifacts; that job id is what this PR changes, so all three are covered. The issue's precondition — check branch protection for a required copy-artifacts context before renaming — was carried out and its result is recorded above.

Closes #27

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 50 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 87c61911-9324-49cc-a76a-a86a84b72bee

📥 Commits

Reviewing files that changed from the base of the PR and between a6fa77c and 2f569ee.

📒 Files selected for processing (1)
  • .github/workflows/git-clean.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thedavidmeister
thedavidmeister merged commit 11437f8 into main Aug 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardise the currency check on git-clean (file, workflow name and job id)

1 participant