Drop the stale snapshot enumeration from Build.sol - #29
Conversation
The comment named `0_1_3`/`0_1_4`/`0_1_5` as the frozen snapshots. `src/generated/` holds `0_1_9` and `0_1_10`, and `LibCloneFactoryReleased` declares `clone-factory@0_1_9` and `clone-factory@0_1_10`, so the list named none that are there and omitted both that are. Deleted rather than corrected: the snapshots are directories in `src/generated/`, the tree cannot drift from itself, and re-listing them here only re-arms the trap at the next release. The clause they sat in is durable and stays — frozen snapshots are append-only and `run()` never regenerates them. Closes #28 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe ChangesBuild documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized documentation-only change that removes an inaccurate snapshot enumeration without changing build or release behavior. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The change satisfies issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
script/Build.solnamed0_1_3/0_1_4/0_1_5as this repo's frozensnapshots.
src/generated/holds0_1_9,0_1_10andcandidate, andLibCloneFactoryReleaseddeclaresclone-factory@0_1_9andclone-factory@0_1_10. The list named none of the snapshots that are there andomitted both that are.
Deleted rather than corrected, per the ruling on rainlanguage/rain.deploy#153.
The frozen snapshots are directories in
src/generated/: the tree is the truthand cannot drift from itself, so re-listing them in prose only re-arms the same
trap at the next release, and nothing expires a comment.
Only the enumeration goes. The clause it sat in is durable and stays: the frozen
snapshots are append-only historical records and
run()never regenerates them,which is what separates
run()fromcutRelease()and is not visible at thiscall site. The two comment lines are a rewrap of the words already there; no
replacement prose was added.
QA
git diff: the only changed lines are two///lines in the@noticeabovecontract Build, and their replacements are the same words minus the enumeration, rewrapped.ls src/generated/gives0_1_9,0_1_10,candidate, andsrc/lib/LibCloneFactoryReleased.solemitssuite: "clone-factory@0_1_9"andsuite: "clone-factory@0_1_10". There is no0_1_3,0_1_4or0_1_5directory to match the deleted list, which is what makes it false, and it is read from the record and the generated lib rather than from any prose.script/Build.sol. Also grepped this repo for0_1_3/0_1_4/0_1_5across*.sol,*.md,*.yamland*.tomloutsidelib/: that line was the only hit.Closes #28
Summary by CodeRabbit