Repository navigation
fix(summary): preserve commitments joined to connection checks - #2252
Merged
Merged
Conversation
…tive clauses Audio confirmations (I can hear you, I can see your screen) count as small talk, so their weak 'i can' cue no longer creates action items. Decision and action classification now uses the clauses left after courtesy phrases are dropped, so a discarded closer's cue can't steal a real action. Fixes #2151
Broad substrings like "hear you" and "see you" also matched "hear your feedback" and "see your concern", so one-clause action items were dropped as small talk. Match audio checks and the see-you sign-off with word-bounded patterns instead, and add a test that real work mentioning someone's input stays an action item.
r3dbars
added
bug
Owner
Author
|
Final review: the complete repair diff was independently approved, its original defect reproduced, and its regression tests passed. Exact repair-head CI is green. Combined candidate 75488fb passed mapped checks, fresh full deterministic QA/build and safe synthetic paste verification; see #2255 for evidence and the explicit native, thin-packaging and release limitations. Ready for the owner-authorized ancestry-preserving integration; no release or live hardware clearance is implied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Fixes #2249. Builds on #2235 and keeps real actions/decisions joined to connection checks without promoting pure audio/screen-share chatter.
Only sentences already on the small-talk/courtesy classification path are split at word-bounded
and,but,sobefore courtesy clauses are removed. Extracted output retains the original sentence and existing decision/action priority.Evidence
No product capability, assertion baseline or check was removed or loosened.