Repository navigation
Module edges: make the boundary rule absolute (merge last) - #2083
Merged
Merged
Conversation
check-module-boundaries.py now fails on every crossing. The baseline file, --shrink and --write-baseline are gone, and the docs that pointed at the baseline say nothing is grandfathered. Merge this after every cleanup/module-edges PR has landed; until then the check fails on main's remaining crossings.
r3dbars
added
cleanup
Owner
Author
|
The auto-merge gate can't merge this on its own (touches protected files: .agents/modules.json, AGENTS.md, Sources/TranscriptedCore/AGENTS.md; files outside lane module-edges: docs/repo-layout.md, scripts/README.md, scripts/dev/check-module-boundaries.py), so it's labeled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge this last. It only goes green once every
cleanup/module-edges/*PR has landed and main has zero module-boundary crossings. Until thencheck-module-boundaries.pyfails on whatever's left. That's on purpose; it's the point of this PR.What changes:
scripts/dev/check-module-boundaries.pydrops the baseline. Every crossing fails, and--shrinkand--write-baselineare gone. If an edge is legit, the fix is a reviewedmayDependOn/ Core tier edit in.agents/modules.json, same as before..agents/module-boundary-baseline.jsonis deleted.AGENTS.md,Sources/TranscriptedCore,UI/OverlayandUI/SettingsAGENTS.md,docs/repo-layout.md,scripts/README.md, themodules.jsoncomment) now say nothing is grandfathered.check-doc-paths.pyneeded these.Before merging:
origin/mainin (a merge commit, not a rebase). Open doc PRs Agent docs: refresh every AGENTS.md and add six missing ones #2030, Auto-merge gate (level 3): cleanup, docs and tested bug fixes #2039 and Threat model and safe maintenance automation playbooks #2052 touch some of the same AGENTS.md files, so expect small conflicts there.python3 scripts/dev/check-module-boundaries.pypasses on the merged head. If any edge was skipped, this PR waits for it..agents/test-matrix.ymlstill lists the deleted baseline path in a trigger glob. It's harmless; I left it because several open PRs edit that file.Checks on this head (before the edge PRs land):
check-module-boundaries.py --self-test: pass.bash check.sh: all passed except the expected boundary failures (37 crossings still on main).swift test: failed once while 7 other worktrees were building, then passed on rerun (1040 tests). This PR changes no Swift.source-stabilityflagged a source change during the proof run; I couldn't explain it.