Repository navigation
Tests: MCP and lab suites pass on a Mac that runs Transcripted - #1892
Merged
Merged
Conversation
MCP: observations resolved their build from the real Application Support, where a running Transcripted saves its version, so a ToolHandlers test saw "1.1.66" on a dev Mac and passed only on clean CI. The build now comes from AgentCaptureQueryTelemetryRuntime.buildIdentity, which the tests point at an empty folder. Production behavior is unchanged. Lab: LabProcessRunner waited with Process.waitUntilExit() from async code. When the child outlived the call (the timeout test run after the other process tests), it parked on a run loop the exit never woke and hung forever. Exit is now observed with terminationHandler, which runs on a background queue whatever thread launched the process. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two package suites failed or hung on a Mac that runs Transcripted, while passing on CI's clean runners. That's the worst kind of test: red locally for no reason, so people learn to ignore it.
MCP: a test saw the real app's version
testReadMeetingBuildsPostHogPayloadFromRealSavedArtifactLookupasserts that the standalone helper reports noapp_version/build_channel/build_revision. On a dev Mac it got1.1.66/local/af5cf8a93577: observations resolved their build from the real~/Library/Application Support/Transcripted, where the running app saves its build info for the helper.The build now comes from
AgentCaptureQueryTelemetryRuntime.buildIdentity, used at both call sites (trackAgentCaptureQueryObservedandwithAgentCaptureQueryTelemetry).ToolHandlersTestspoints it at an empty temp folder insetUpand restores it intearDown. Production is unchanged (same.resolve()default).Lab: the timeout test hung forever
testProcessTimeoutStopsChildrenThatIgnoreTerminationhung at 0% CPU insideLabProcessRunner.run, both inside and outside the sandbox. It passed alone (3 s) and hung every time after the other process tests. The runner waited withProcess.waitUntilExit()from async code. When the child outlived that call, it parked on a run loop that the exit notification never woke. Exit is now observed withterminationHandler, which Foundation calls on a background queue whatever thread launched the process, and the async loops wait on that flag. The otherwaitUntilExit()in the lab (gitRevision, synchronous and on one thread) is left as is.How I checked it
setUpline, the same test fails here again (3 failures).check-test-shape(self-test and guard),check-source-pins --changed-only,swift test --package-path Tools/TranscriptedLab --jobs 4, both lab products built,build_and_run.sh --verify,swift test --package-path Tools/TranscriptedMCP,bash run-e2e-smoke.sh.🤖 Generated with Claude Code