build(deps): bump ulid from 1.2.1 to 3.0.0 in /quickwit - #6743
build(deps): bump ulid from 1.2.1 to 3.0.0 in /quickwit#6743dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [ulid](https://github.com/dylanhart/ulid-rs) from 1.2.1 to 3.0.0. - [Commits](dylanhart/ulid-rs@v1.2.1...v3.0.0) --- updated-dependencies: - dependency-name: ulid dependency-version: 3.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
17d5be4 to
3fc45e0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3fc45e0ca0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ttl_cache = "0.5" | ||
| typetag = "0.2" | ||
| ulid = "1.2" | ||
| ulid = "3.0" |
There was a problem hiding this comment.
Migrate callers before selecting ulid 3
Version 3 removes Ulid::new, but the reviewed tree still calls it throughout production crates, including quickwit-proto/src/types/doc_uid.rs:49, quickwit-indexing/src/actors/indexer.rs:194, and quickwit-search/src/scroll_context.rs:195. Consequently, compiling any of these crates against this workspace dependency fails until the call sites are migrated to the v3 API.
AGENTS.md reference: AGENTS.md:L121-L121
Useful? React with 👍 / 👎.
Bumps ulid from 1.2.1 to 3.0.0.
Commits
90992f5Bump version to v3.0.01d6ad4eEnable warn(keyword_idents) and replace gen usages82c545aFix wasm32 builda30176cCleanup in prep for release1af7ec8bump version to v2.0.013b3614Cleanup clippy warningsce49f86Add the ability for Generator to overflow5fe66d5Remove deprecated method4ac1cf7Rename Ulid::new -> Ulid::gen; add Ulid::max926ebfaUpdate rand to v0.10