build(deps): bump google-cloud-gax from 0.19.2 to 1.14.0 in /quickwit in the google-cloud group across 1 directory - #6740
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37a0634526
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # of google-cloud-pubsub is "0.30" which explicitly depends on: google-cloud-auth ^0.17 and google-cloud-gax ^0.19. | ||
| google-cloud-auth = { version = "0.17", default-features = false, features = ["rustls-tls"] } | ||
| google-cloud-gax = "0.19" | ||
| google-cloud-gax = "1.13" |
There was a problem hiding this comment.
Keep GAX on the Pub/Sub-compatible major
When quickwit-indexing is built with gcp-pubsub (including the repository's --all-features checks), this direct dependency resolves to GAX 1.14, while google-cloud-pubsub 0.30 still resolves GAX 0.19.2 (Cargo.lock lines 4635-4644). Consequently, gcp_pubsub_source.rs imports RetrySetting from the 1.x crate and passes it to Subscription::exists, whose API is compiled against the distinct 0.19 crate, so the GCP feature no longer builds. Keep the direct dependency on 0.19 until Pub/Sub can be upgraded with it.
AGENTS.md reference: AGENTS.md:L121-L121
Useful? React with 👍 / 👎.
| name = "google-cloud-rpc" | ||
| version = "1.6.0" |
There was a problem hiding this comment.
Regenerate the third-party license inventory
This lockfile update introduces the new google-cloud-rpc and google-cloud-wkt packages, but the commit does not update LICENSE-3rdparty.csv, where neither package is currently listed. The thirdparty-license CI job runs dd-rust-license-tool ... check, so it will reject the stale inventory; run make update-licenses and commit the regenerated file with the dependency update.
AGENTS.md reference: AGENTS.md:L106-L106
Useful? React with 👍 / 👎.
Bumps the google-cloud group with 1 update in the /quickwit directory: [google-cloud-gax](https://github.com/googleapis/google-cloud-rust). Updates `google-cloud-gax` from 0.19.2 to 1.14.0 - [Release notes](https://github.com/googleapis/google-cloud-rust/releases) - [Commits](https://github.com/googleapis/google-cloud-rust/commits) --- updated-dependencies: - dependency-name: google-cloud-gax dependency-version: 1.13.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: google-cloud ... Signed-off-by: dependabot[bot] <support@github.com>
37a0634 to
b04e8ef
Compare
Bumps the google-cloud group with 1 update in the /quickwit directory: google-cloud-gax.
Updates
google-cloud-gaxfrom 0.19.2 to 1.14.0Release notes
Sourced from google-cloud-gax's releases.
Commits