Repository navigation
test(qwp): tolerate early terminal error ACK in regression test - #111
Merged
Merged
Conversation
Contributor
Author
|
Review of PR #111 at level 1: approve. It changes only the test, and the fix is correct. The PR wraps the first
The changed test class passed 5 out of 5 runs on the PR head ( CriticalNone. ModerateNone. Minor
Coverage mapNo production code changed, so every row is exempt. The test gate passes with no coverage gaps. No tandem PR is needed: it's a unit-test-only change, and searching Summary
|
jovfer
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server's terminal error ACK can arrive before the first
flush()returns, makingServerErrorAckTerminalTestfail on valid sender behavior. TolerateLineSenderExceptionfrom that initial flush while retaining the assertions that the error stays terminal and no reconnect attempts occur.Fixes #110.